search

noeppi-noeppi / BingoLobby

A lobby for the bongo mod
Apache License 2.0
1 stars 2 forks source link

Players Continually Teleported when Non-VIP or No Game Created #11

Open Keegans opened 3 months ago

Keegans commented 3 months ago

Hello! There is an issue with the event listeners not refreshing their state after teleporting a player.

There are two example of this: 1) When a game is NOT created and a player moves onto carpet 2) A non-VIP player moves on to the VIP carpet

It feels like the event listener keeps saying that the player is in violation and must keep getting teleported (and get the event notification in chat).

So to recreate this issue, log into a lobby, step on carpet.

I have a work around in place on my lobby that is a @a tp command block. If the player is teleported again, it will clear out the issue (it seems like maybe it then resets the listeners? No idea I am really guessing).

Keegans commented 3 months ago

I wonder if adding the following line at line 58 of \BingoLobby-master\src\main\java\io\github\noeppi_noeppi\mods\bingolobby\EventListener.java will correct this issue.

color = block instanceof WoolCarpetBlock ? ((WoolCarpetBlock) block).getColor() : null;

(Its been awhile since I have coded in Java, but I think its just missing a check in the event handler there that will, by default, set the color variable back to null, which should release the player... I think)