search

noeppi-noeppi / Bongo

A Minecraft Bingo Minigame Mod
https://www.curseforge.com/minecraft/mc-mods/bongo
Apache License 2.0
13 stars 20 forks source link

Add an Ignore NBT option #47

Closed TBiscuit1 closed 2 years ago

TBiscuit1 commented 2 years ago

Bongo only consider items that has an identical NBT, this include no-NBT

Because of that, items that can have NBT data inside of them will become invalid for completion, this include :

Potions Tools/Armor that aren't full durability or that has enchants Filled Maps Written Books Fish/Axolotl Buckets Named Item Banners

Adding a "Ignore NBT" condition would fix this problem

Here is an exemple (while it is custom, it happens on non-modified bongo) image In this case, I have a stone axe, but since it lost 1 durability, it won't count

Edit: Reformated my message

noeppi-noeppi commented 2 years ago

Are you using the default bingos or custom ones? And if you have custom bingos, could you send the game definitions please?

TBiscuit1 commented 2 years ago

The bug happened on the default one too (one of my streamer friend did an event and encountered the problem) I remember someone not being able to complete a task because their shield had lost durability (they found someone else's shield)

Here was the original custom I made (On the very next version I changed the broken ones to stats as a temporary bypass) Extra_Bingo.zip

TBiscuit1 commented 2 years ago

image I think I found the issue, you are checking if the tool are the same without the durability, but then check the nbt and that INCLUDE "Damage:Int" which is the durability

So the check fails to account for durability

Edit: I would say that you should add "ignore nbt" option for task so this issue is fixed

Edit 2 : During the mean time, since now I know how Java work, I'll try to fix the original issue myself and do a PR

Edit 3 : PR in question : #57