search

noescape00 / DiscordTipBot

Tipping bot for discord that supports STRAT and other cryptocurrencies
GNU General Public License v3.0
5 stars 9 forks source link

StartQuiz command showing the salted hash #13

Closed miguelvazsilva closed 6 years ago

miguelvazsilva commented 6 years ago

Hello noescape00, i'm msssss, from the Stratis Discord, hope you don't mind that i post here some suggestions and hopefully some bugs about the Discord tipbot you developed.

Some users warned me about being possible to see the salted hash when the StartQuiz command is posted, that doesn't seem alright, there should be a better solution, rather than having to manually delete the command, some possible workarounds: 1 - Just accept the StartQuiz command from a direct message of the user to the tipbot (It's possible right? ), and it would be the tipbot to post automatically the quiz in the Tipping section; 2 - The tipbot could remove automatically the message from the user that ordered the StartQuiz (It's possible to do that by making the tipbot a moderator?).

Thanks, best regards

noescape00 commented 6 years ago

Yes, that's a good idea.

First option is probably not the correct way since the bot is supposed to support being added and used in different channels and servers.

I'll probably go with 2nd option and make bot delete the StartQuiz message that contains hash.

Bot will edit user's startQuiz message and replace hash with hash was here but it was removed for security reasons

noescape00 commented 6 years ago

fixed in https://github.com/noescape00/DiscordTipBot/commit/93dab1e0a9907e905911b44c7d5d2f8f31a3df84