noeticpenguin / ngForce

Force.com && Angular.js integration framework.
noeticpenguin.github.io/ngForce
MIT License
142 stars 61 forks source link

Added external config JS file as a Visualforce page to handle SFDC merge... #23

Closed amarchbanks closed 10 years ago

amarchbanks commented 10 years ago

Let me know what you think of this. I'm working on modifying the core to incorporate the external file, I'll send you another pull request later.

amarchbanks commented 10 years ago

Only with VFR calls. Can you give some details on the concerns over the memory leak possibility?

noeticpenguin commented 10 years ago

@amarchbanks I just did a bunch of testing and I couldn't find a mem leak; so ignore my comment.

noeticpenguin commented 10 years ago

@amarchbanks I'm going to merge this, but not until i've fixed the documentation and updated it to note how to use this. Feel free to make a documentation PR. ;)

amarchbanks commented 10 years ago

@noeticpenguin cheers for the testing. I've committed some documentation...good enough for a merge?

noeticpenguin commented 10 years ago

@amarchbanks Beautiful, and thanks! Merging.