Closed Oblongmana closed 9 years ago
Couple of other points, I haven't rebuilt this using grunt min
(which I think is your build process?), as https://github.com/noeticpenguin/ngForce/commit/e2bcc141d8ec086c1a0257f3a3b01bee3fd700ee broke the build (standardOpts is declared inside an object literal, as a var, which explodes ngAnnotate). Can do another PR to fix that as well if you like? But there were a few approaches to fix that which i could see, and I didn't want to presume to take either - you could either:
var standardOpts
in the provider, and instead of returning an object with $get
and setStandardOptions
, put the methods on this
(following the pattern described here: https://docs.angularjs.org/guide/providers#provider-recipe)standardOpts
references in $get
and setStandardOptions
to be this.standardOpts
James,
Regarding your other points,
I would love a PR to fix this. I apologize for breaking the build. I would love if you would submit a PR that followed the pattern you linked to in the provider recipe.
James, I would still love the other PR to fix the provider.
Hey Kevin, good to hear from you too!
Looks like you landed on my issue with the explanation of nullOk
handling, but to confirm, yep, should be 100% backwards compatible :+1:
Will try and get a PR in for the provider fix today-ish
Resolves #32 and #34 (see those issues for detailed descriptions):
Summary: