search

nofaceinbook / muxp

Mesh Updater X-Plane
GNU Lesser General Public License v3.0
18 stars 3 forks source link

too strict assumptions for setting "xpfolder: [INSIDE]" #28

Closed marangonico closed 4 years ago

marangonico commented 4 years ago

The settings "xpfolder: [INSIDE]" checks for a folder named "X-Plane 11". This assumption is too much restrictive, since there could be more than one X-Plane installation present. I suggest to check a couple of elements, in order to detect if we are inside a valid X-Plane folder. Items to check could be (in no particular order):

nofaceinbook commented 4 years ago

Yes, could be changed. But as it is, it would support several X-Plane 11 installations. It is unclear whether muxp will work correctly for other X-Plane versions and for future versions it would also not be sure, wether they have X-Plane.exe or scenery_packs.ini.

marangonico commented 4 years ago

When I refer to more than X-Plane installation, I mean more than one X-Plane 11. And since the name can be changed (in my case is different), it is probably a weak check.

nofaceinbook commented 4 years ago

Yes. Understood. Thought, that the name for X-Plane root folder is fixed. So will try checks as you mentioned.

nofaceinbook commented 4 years ago

Should work now. Would be great if you @marangonico could check...

marangonico commented 4 years ago

Will try and report back.

marangonico commented 4 years ago

Tried and it works, but I'd check that both conditions are satisfied.

nofaceinbook commented 4 years ago

@marangonico: can we close this issue?

marangonico commented 4 years ago

As I said, I'd check both conditions, not just one. Other than that, you can close it.