search

nofatigue / runelite-profit-tracker

A runelite plugin for tracking profit while money-making.
BSD 2-Clause "Simplified" License
3 stars 18 forks source link

Added config option for overlay #20

Closed CoryRobertson closed 3 years ago

CoryRobertson commented 3 years ago

Added config option to overlay so you can just have the gold drops By the way, this is my first time working with runelite plugins, I'd love to get some feedback if this is a good change at all, or if there are better ways this can be done! Thanks for your time!

nofatigue commented 3 years ago

Hi, I'm glad you wanted to work with this code and add a feature :) I've added a comment on your code. But I must inform you: Since I own the repo but no longer actually maintain it, even If the pull requested is merged, I might not actually update it with the runelite plugin repo. And another thing: Currently I'm talking with someone that might fork and update the repo in the future. So in case he forks before your code is merged, your code will not be in his fork. I'm sorry for this timing. If you choose to close this pull request or leave it as it is - it is understandable.

CoryRobertson commented 3 years ago

Hi, I'm glad you wanted to work with this code and add a feature :) I've added a comment on your code. But I must inform you: Since I own the repo but no longer actually maintain it, even If the pull requested is merged, I might not actually update it with the runelite plugin repo. And another thing: Currently I'm talking with someone that might fork and update the repo in the future. So in case he forks before your code is merged, your code will not be in his fork. I'm sorry for this timing. If you choose to close this pull request or leave it as it is - it is understandable.

That's totally ok, I more just wanted to learn how making a runelite plugin works and wanted to get the experience of making a pull request, no worries at all!