search

nofatigue / runelite-profit-tracker

A runelite plugin for tracking profit while money-making.
BSD 2-Clause "Simplified" License
3 stars 18 forks source link

Incorrect calculation involving rune pouch #8

Open fishies opened 4 years ago

fishies commented 4 years ago

Expected: placing runes into the rune pouch should not affect profit calculation.

Observed: placing runes into the rune pouch is erroneously counted as an expense/loss.

I have not yet tested to see if this same oversight applies to similar items such as the looting bag, bolt pouch, coal bag, or gem bag.

chrstfer commented 4 years ago

I can confirm that the same thing happens with the bolt pouch, and the tool leprechaun. It seems as if the plugin is only watching your inventory/equipment/bank, ignoring all other containers you control.

NoctrisCode commented 3 years ago

Using runes from within the rune pouch also are not counted as a cost. For example casting High Alch with fire and nature runes in the rune pouch will not take into account the cost of the nature runes or fire runes that are consumed.

robinschuere commented 3 years ago

Using runes from within the rune pouch also are not counted as a cost. For example casting High Alch with fire and nature runes in the rune pouch will not take into account the cost of the nature runes or fire runes that are consumed.

Also, adding runes to the runepouch is handled as a loss. Perhaps the logic behind this can be used ...