search

noflo / noflo-image

Image processing components for NoFlo.
MIT License
13 stars 9 forks source link

Node.js 4 #66

Closed jonnor closed 8 years ago

jonnor commented 8 years ago

@automata what do you think can be the cause of these failures, and do you consider them critical?

automata commented 8 years ago

@jonnor those failures show values not that different from what is expected, but I'll take a look on that closely before we do changes on tests or components themselves. What bothers me is why we're getting those values now and what changed on node-canvas, jsfeat or somewhere else that gives those values now.

BTW they're only related with jsfeat except the first test, right? Maybe we should bump jsfeat too.

jonnor commented 8 years ago

jsfeat has not changed. I suspect the changes come from node-canvas, but I have not checked

automata commented 8 years ago

@jonnor it's green now.