search

noflo / noflo-runtime-msgflo

NoFlo runtime for AMQP/MQTT
10 stars 8 forks source link

chore(package): update mocha to version 4.0.1 #215

Closed bergie closed 6 years ago

bergie commented 6 years ago

Closes #207

bergie commented 6 years ago

Kind of curious how the build hangs after all tests pass. Seeing same behavior with noflo/noflo-runtime-websocket#77

@jonnor ideas?

jonnor commented 6 years ago

@bergie Mocha 4 will no longer forcefully stop the tests when done. So any nodejs thing still active will keep it hanging. Mentioned in its changelog

bergie commented 6 years ago

@jonnor ok, so the issue is that we have some MQTT/AMQP connections left hanging or somesuch?

jonnor commented 6 years ago

Yes or any other deferred thing, like a setInterval. msgflo-nodejs is happy with Mocha 4 though. Probably need to check with one of the Nodejs debugging tools for this kind of problem

bergie commented 6 years ago

Here is a way to see what's hanging: https://stackoverflow.com/a/32617487/263570