search

noflo / noflo-ui

NoFlo Development Environment
https://app.flowhub.io
MIT License
768 stars 173 forks source link

Log FBP runtime protocol errors #290

Closed jonnor closed 10 years ago

jonnor commented 10 years ago

Right now errors in the FBP protocol are ignored silently by the UI, which makes it a bit hard to figure out why things are not working as expected when implementing a new runtime.

jonnor commented 10 years ago

Might need to be solved partially in noflo-runtime, though the specific error handling should occur in noflo-ui

djdeath commented 10 years ago

Here is a demo of some work I've been doing in the last week : https://www.youtube.com/watch?v=MS9apvEo9YA

This shows how the UI could show exceptions/uncatch-errors happening in the runtime.

djdeath commented 10 years ago

b0xhh

djdeath commented 10 years ago

https://github.com/noflo/noflo/pull/253 https://github.com/noflo/noflo-runtime-base/pull/13 https://github.com/noflo/noflo-runtime/pull/7 https://github.com/the-grid/the-graph/pull/154

I don't have a pull request for noflo-ui because I did this on a modified version of the UI, but it's fairly simple (ie. 2 buttons & 2 graph connections to the new noflo-runtime components).

bergie commented 10 years ago

@djdeath those are all merged now. Thanks!

djdeath commented 10 years ago

Great, thanks! We need a change in noflo-ui now to have that feature enabled for users. Maybe some additional logging on the components view. I shall send a patch to noflo too, to serialize the backtrace.

djdeath commented 10 years ago

5499e47f4abb02bd0d0e611bcc1e506a8d7988b3 added a log of errors in the node inspector : https://www.youtube.com/watch?v=Gp-qUZSLLHY

I guess that closes this issue?

bergie commented 10 years ago

@djdeath thanks!