Closed borromeotlhs closed 10 years ago
This is from the beta preview of flowhub ui from the chrome web store.
I'm unable to login altogether (regardless of having entered correct credentials). There's an error in the console about a 404 error for https://flowhub-gate.herokuapp.com//authenticate/really-long-token
. Note that there's double slashes in the url, before "authenticate". When I manually query this with corrected slashes, it responds successfully with a token.
OK, cool, but that URL is the one the app spits out. It is a bug, and though I could manually work around it, it begs the question as to why the flowhub app is doing it in the first place.
Thanks, TJ On Aug 2, 2014 4:05 PM, "Amit Sch" notifications@github.com wrote:
I'm unable to login altogether (regardless of having entered correct credentials). There's an error in the console about a 404 error for https://flowhub-gate.herokuapp.com//authenticate/really-long-token. Note that there's double slashes in the url, before "authenticate". When I manually query this with corrected slashes, it responds successfully with a token.
— Reply to this email directly or view it on GitHub https://github.com/noflo/noflo-ui/issues/302#issuecomment-50977115.
+1
I experience the same problem and miss playing with the UI so much I've decided to get to the bottom of this.
Problem:
The URL parameter is defined here with slash: https://github.com/noflo/noflo-ui/blob/master/Gruntfile.coffee#L86
The noflo-account
element expects the url without slash:
https://github.com/noflo/noflo-ui/blob/master/elements/noflo-account.html#L332
https://github.com/noflo/noflo-ui/blob/master/elements/noflo-account.html#L207
The manifest probably needs the url with slash: https://github.com/noflo/noflo-ui/blob/master/manifest.dist.json#L17
Convention for the noflo-account
element seems to be without slash, the permissions
convention is with slash.
The manifest permissions seem to require slashes: https://developer.chrome.com/extensions/declare_permissions
Some possible solutions:
noflo-account
element to normalize the url.noflo-account
element to expect urls with slashes.Add a slash within the manifest, like so: "$NOFLO_OAUTH_GATE/"
.
However, since the Gruntfile also allows the environment to set this url using process.env.NOFLO_OAUTH_GATE
, any environment setting this will also have to be updated.
Since we haven't pushed a new version recently, this is probably an API change that might be able to be fixed to allow // ... @bergie ?
But we should fix it on both ends.
Thanks for reporting this! We'll deploy a fix soon (@forresto wanted to make a release anyway)
I failed logging in, and now, I cannot seem to get the username and password prompt to attempt logging in again.