noflo / noflo-ui

NoFlo Development Environment
https://app.flowhub.io
MIT License
767 stars 173 forks source link

Can't login once you incorrectly enter your login credentials #302

Closed borromeotlhs closed 10 years ago

borromeotlhs commented 10 years ago

I failed logging in, and now, I cannot seem to get the username and password prompt to attempt logging in again.

borromeotlhs commented 10 years ago

This is from the beta preview of flowhub ui from the chrome web store.

meetamit commented 10 years ago

I'm unable to login altogether (regardless of having entered correct credentials). There's an error in the console about a 404 error for https://flowhub-gate.herokuapp.com//authenticate/really-long-token. Note that there's double slashes in the url, before "authenticate". When I manually query this with corrected slashes, it responds successfully with a token.

borromeotlhs commented 10 years ago

OK, cool, but that URL is the one the app spits out. It is a bug, and though I could manually work around it, it begs the question as to why the flowhub app is doing it in the first place.

Thanks, TJ On Aug 2, 2014 4:05 PM, "Amit Sch" notifications@github.com wrote:

I'm unable to login altogether (regardless of having entered correct credentials). There's an error in the console about a 404 error for https://flowhub-gate.herokuapp.com//authenticate/really-long-token. Note that there's double slashes in the url, before "authenticate". When I manually query this with corrected slashes, it responds successfully with a token.

— Reply to this email directly or view it on GitHub https://github.com/noflo/noflo-ui/issues/302#issuecomment-50977115.

rschwabco commented 10 years ago

+1

rhalff commented 10 years ago

I experience the same problem and miss playing with the UI so much I've decided to get to the bottom of this.

Problem:

The URL parameter is defined here with slash: https://github.com/noflo/noflo-ui/blob/master/Gruntfile.coffee#L86

The noflo-account element expects the url without slash: https://github.com/noflo/noflo-ui/blob/master/elements/noflo-account.html#L332 https://github.com/noflo/noflo-ui/blob/master/elements/noflo-account.html#L207

The manifest probably needs the url with slash: https://github.com/noflo/noflo-ui/blob/master/manifest.dist.json#L17

Convention for the noflo-account element seems to be without slash, the permissions convention is with slash.

The manifest permissions seem to require slashes: https://developer.chrome.com/extensions/declare_permissions

Some possible solutions:

forresto commented 10 years ago

Since we haven't pushed a new version recently, this is probably an API change that might be able to be fixed to allow // ... @bergie ?

But we should fix it on both ends.

bergie commented 10 years ago

Thanks for reporting this! We'll deploy a fix soon (@forresto wanted to make a release anyway)