search

noflo / noflo-ui

NoFlo Development Environment
https://app.flowhub.io
MIT License
768 stars 173 forks source link

Initial commands not send to runtime on connect #346

Closed jonnor closed 10 years ago

jonnor commented 10 years ago

When starting a new project, and adding new nodes/edges, the first message I see after component loading is: RECV: {"protocol":"graph","command":"addnode","payload": "id":"Processor_7pq2b","component":"Processor","metadata": {"label":"Processor","x":334,"y":100},"graph":"main"}}

When closing that project, and opening again, the current state is also not transferred. With 3 nodes and 2 edges, I don't see any graph messages reach runtime at all.

This breaks imgflo, and probably most other runtimes too.

Good candidate for some automated tests, building a graph + opening a project, verifying messages sent on runtime protocol. Tested on commit 670b410efaf824fbc282e4a8cfe12dbb4c7a5a2a

jonnor commented 10 years ago

@bergie What part of the code is supposed to handle updating runtime when loading project?

bergie commented 10 years ago

@jonnor start from https://github.com/noflo/noflo-ui/blob/master/graphs/RuntimeStorage.fbp

bergie commented 10 years ago

@jonnor the problematic part might be https://github.com/noflo/noflo-ui/blob/master/components/ContextToRuntime.coffee#L96

jonnor commented 10 years ago

Was bug in imgflo, fixed in jonnor/imgflo@9087842681180f36d1b53572a8fc576a8b82f9ed