search

noflo / noflo-ui

NoFlo Development Environment
https://app.flowhub.io
MIT License
767 stars 173 forks source link

"please re-login" message button doesn't work #395

Closed forresto closed 9 years ago

forresto commented 9 years ago

screen shot 2014-11-12 at 5 53 22 pm

Trying to sync fails. That button refreshes app.flowhub.io twice, but I'm still logged in.

Revoking The Grid permission in Github and logging out at passport.thegrid.io and app.flowhub.io:

GitHub asks for permissions on next login, but only for public access:

screen shot 2014-11-12 at 5 53 56 pm

And we're back where we started.

bergie commented 9 years ago

@forresto you shouldn't need to do anything on GitHub side. The button causes Grid Passport to request private repo access

forresto commented 9 years ago

Only did that after the other stuff didn't work. That button refreshes app.flowhub.io twice, doesn't ask for permissions. @jonnor said he reproduced in incognito window.

forresto commented 9 years ago

@bergie can you check that the Grid Passport is requesting the permissions? I'm not seeing any GitHub prompt on relogin.

bergie commented 9 years ago

@forresto please ensure that the provider part of the URL is github_private, not github_public

jonnor commented 9 years ago

Could be due to a change in #386, migth be worth testing before it.

bergie commented 9 years ago

@jonnor confirmed, not using params.provider any longer so it always authorizes with public access: https://github.com/piotras/noflo-ui/commit/1afd787ed7e3e209fe8ab546f9a736f8d15dc688

forresto commented 9 years ago

Thanks for looking into this. Easy fix?

forresto commented 9 years ago

Confirmed fix with live 0.5.2.