nognkantoor / bpbible

Automatically exported from code.google.com/p/bpbible
Other
0 stars 0 forks source link

Search can not find slothful as an extension of sloth #248

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
What steps will reproduce the problem?
1. Select a bible, KJV with Strongs for example
2. Select Search, when it opens, use default settings except select NT only.
3. Type in sloth, without any quotes, and press SEARCH button

What is the expected output? 
Returns the following verses: Matthew 25:26, Romans 12:11, and Hebrews 6:12 
with the word 'slothful' in each verse. Why, because 'slothful' is a logical 
extension of 'sloth', as in if I type in the word sin. With that search I get 
verses with; sins, sinner, sinners, sinful, sinning, etc....

What do you see instead? The result is that I get an information box saying 
that the word sloth is not found in this bible.

What version of the product are you using? Is it the PortableApps Yes
BP Bible 0.5.2
Python 2.6.6
wxPython 2.8.12.1
Sword 1.6
xul Runner 1.9.2

On what operating system? Win 7 Home Premium  

If the problem happens with one particular module (Bible, commentary,
dictionary, or book), what module is it? Search Module

Please provide any additional information below.

Original issue reported on code.google.com by wcl.k...@gmail.com on 19 Aug 2014 at 2:28

GoogleCodeExporter commented 8 years ago
Sorry for not responding earlier, but basically the answer is that stemming is 
an imperfect solution (yes, it would be better for slothful to be counted as 
"sloth").  However, because we are not doing any of the work of stemming we 
cannot change its behaviour - we just take what is given.

Original comment by jonmmor...@gmail.com on 3 Sep 2014 at 12:59

GoogleCodeExporter commented 8 years ago
Sorry, I clearly didn't read your comment carefully enough.
Stemming will treat "slothful" and "sloth" as the same, so your search would 
work if there was at least one use of "sloth" in the book.
However, it looks like when we are checking "Is this word in the current book" 
we're just checking the word, rather than whether there are any other stemmed 
versions of the word.
We should fix this.

Original comment by jonmmor...@gmail.com on 3 Jan 2015 at 12:28

GoogleCodeExporter commented 8 years ago
Fixed in r1426.

Original comment by jonmmor...@gmail.com on 4 Jan 2015 at 11:34