nogre / ping-skill

MIT License
0 stars 5 forks source link

Too aggressive with keywords #2

Open chowbok opened 6 years ago

chowbok commented 6 years ago

Hi... this plugin interferes with the wiki skill; I can't request an article on "pink floyd" because this intercepts the "pink". Can something be done to make this not listen when the request starts with "wiki" or "tell me about" or one of the other wiki skill triggers?

nogre commented 6 years ago

Interesting. I don't know about how to keep different skill keywords from conflicting, but you can delete pink from the ping-skill/vocab/en-us/PingKeyword.voc and ping-skill/regex/en-us/key.rx files so it won't get registered with this skill.

penrods commented 6 years ago

For now, there isn't a disambiguation method. In the future the base technology will have some additional mechanisms to assist. Namely:

But those are both still a ways away. For now, I'd recommend you remove "pink" and "pin" from the vocabulary. It might require a few retrys to trigger the skill, but that is better than getting odd results from intentionally giving it incorrect vocabulary.

Additionally, STT is often better with common context. So migrating towards support of phrases like:

Will likely give you better results. Unfortunately, getting TTS to recognize an IP address is also gonna be tricky, so you will likely have better results manually parsing the utterance instead of expecting Regex to match it. For example, when I said "ping ip 10.10.40.203" it got transcribed as: ping ip 10.20.14 203 Because of how I pronounced it.

jrwarwick commented 5 years ago

@chowbok I believe the now merged PR #10 addresses the issues you and penrods discussed. If you'd like to give it another try, I think this issue may be ready for closure.