search

nohamelin / simple-locale-switcher

Easier management of the user interface language in Mozilla applications
Mozilla Public License 2.0
11 stars 4 forks source link

hu (magyar - Hungarian) translation #31

Open ovari opened 5 years ago

ovari commented 5 years ago
  1. Please accept pull requests: https://github.com/nohamelin/simple-locale-switcher/pull/19 https://github.com/nohamelin/simple-locale-switcher/pull/20 https://github.com/nohamelin/simple-locale-switcher/pull/21 https://github.com/nohamelin/simple-locale-switcher/pull/22 https://github.com/nohamelin/simple-locale-switcher/pull/23 https://github.com/nohamelin/simple-locale-switcher/pull/24 https://github.com/nohamelin/simple-locale-switcher/pull/25 https://github.com/nohamelin/simple-locale-switcher/pull/26 https://github.com/nohamelin/simple-locale-switcher/pull/27 https://github.com/nohamelin/simple-locale-switcher/pull/28 https://github.com/nohamelin/simple-locale-switcher/pull/29 https://github.com/nohamelin/simple-locale-switcher/pull/30.

Edit: Converted all the above to a single pull request https://github.com/nohamelin/simple-locale-switcher/pull/34.

  1. How does locale simplels hu jar:chrome/locale.jar!/hu/ get added to line 17 of the chrome.manifest file? Currently it shows ### @extra-locales-registration-placeholder@.

  2. BabelZilla was not working for us. It looks like BabelZilla's website form is missing the letter l in their hostname, i.e. techadmin@babezilla.org should be techadmin@babelzilla.org. When we contacted Babelzilla using their website Contact form, the following email message was received:

    <techadmin@babezilla.org> (expanded from <siteadmin@babelzilla.org>): Host or
domain name not found. Name service error for name=babezilla.org type=AAAA:
Host not found

Thank you

nohamelin commented 5 years ago
  1. Sure. I will do the integration today or else during the next weekend. Thanks for your work.
  2. It's done by a personal build script. It's not part of the repository as it still depends on some manual steps...
  3. Babelzilla has been harldy supported since a few years; I'm not relying on it anymore. Until I can check an alternative for it: a) Limiting us to github is OK, and, b) I will not land new strings in the extension anyway.
ovari commented 5 years ago

Can you upload the translations of Simple Locale Switcher for ATN?

It would be similar to:

What do you think?

Thank you for your wonderful add-on.

ovari commented 5 years ago 
2. It's done by a personal build script. It's not part of the repository as it still depends on some manual steps...

Can the source code for your add-on be updated so that it does not require a JAR file? https://developer.mozilla.org/en-US/docs/Archive/Add-ons/Install_Manifests#file

nohamelin commented 5 years ago

Can the source code for your add-on be updated so that it does not require a JAR file?

Sorry, but I will not change it, as the usage of an uncompressed .jar allows me to reduce considerably the size of the resulting .xpi file.

And without the build tools in the repo (it will not happen soon...), leaving other locales besides en-US and es-ES registered in chrome.manifest can cause problems to people building the add-on manually from the repo, as I can't guarantee that those other locales are 100% complete, and XUL Gecko really don't like to find incomplete locales at runtime.

ovari commented 5 years ago 
1. Sure. I will do the integration today or else during the next weekend. Thanks for your work.

@nohamelin is there something else you require from us to enable the merge of https://github.com/nohamelin/simple-locale-switcher/pull/34? Thank you

nohamelin commented 5 years ago

Sorry, I will work in it during the week.

ovari commented 5 years ago

Thank you

nohamelin commented 5 years ago

Merged via 1e902a3. The changes related to translators credits is something that I leave out for now for further revision later. I'm keeping a local copy of your branch due to it, so you can delete your fork without problems.

I will end the TB60 changes as soon as possible so your translation can go live. Again, thanks for your work.

ovari commented 5 years ago

  1. Thank you for your advice, the fork has been deleted.

  2. Thank you for updating your add-on to support TB60 as soon as possible as it can help your users and @jotasprout https://github.com/thundernest/thunderbird-website/issues/36#issuecomment-439415449.

  3. When you have an xpi that works with TB60 please advise and if you like we can test it before it goes live at ATN.

  4. Can you please use the Hungarian text https://github.com/nohamelin/simple-locale-switcher/issues/31#issuecomment-431621041 to update ATN with:

    • Title Simple Locale Switcher → Területi kapcsoló (Simple Locale Switcher)
    • Just under title and author An easier management of the user interface language → A felhasználói felület nyelvének könnyebb kezelése

Thank you once again.

nohamelin commented 5 years ago
  1. Done