Closed ovari closed 5 years ago
@ovari Please use the original add-on name in preferences-os.dtd and preferences-os.win.dtd. The name is used as a "brand" name and not as a descriptive name, so it's not translated by any locale.
Thank you @nohamelin for your message.
This is similar to: Névjegyzék (CardBook) https://addons.thunderbird.net/hu/thunderbird/addon/cardbook/ Tömörített fejléc (CompactHeader) https://addons.thunderbird.net/hu/thunderbird/addon/compactheader/ Üzenet átirányítás (Mail Redirect) https://addons.thunderbird.net/hu/thunderbird/addon/mailredirect/ Thunderbird-összehangolás (TbSync) https://addons.thunderbird.net/hu/thunderbird/addon/tbsync/
Names of a "brand" can vary between locales (or countries). For example Holden and Opel are different "brand" names for the same car. Sometimes the model is the same, for example "Astra", being a Holden Astra or Opel Astra.
@nohamelin Are you able to accept the PR as is or do you need further action from us? Thank you
When I published this add-on, I was aware of the different approaches taken by some other add-ons about this subject, and I decided then don't use localized names. But, now, OK: let's go with "Területi kapcsoló (Simple Locale Switcher)" as an official name.
The overall local status of the pull is OK, though I skipped your changes proposed to the readme: I'm updating this file on my own, and I prefer to write it by myself.
Are you able to accept the merge or do you need us to remove the readme? Thank you
I will do the remaining changes. Thanks.
Please advise when you have accepted so we can delete our fork of your add-on. Thank you
@nohamelin could you please advise the status of this pull request? Thank you
@nohamelin could you please advise when you can accept this pull request to enable us to delete our fork. Thank you
Sorry for the delay; it will be tomorrow.
Thank you
Merged via 1e902a3.
https://github.com/nohamelin/simple-locale-switcher/issues/31
Converted multiple to single merge request.