search

nohello-net / site

MIT License
1.04k stars 215 forks source link

it's 2024 #201

Open Xyndra opened 4 months ago

Xyndra commented 4 months ago

Make the year dynamic

Endemoniada commented 4 months ago

I agree

markmcintyre commented 4 months ago

Looking at the code, the year is already dynamic. I'm guessing the page is being cached somehow?

marc-bouvier commented 4 months ago

Laste deployment is 2022. I suppose it explains this issue.

marc-bouvier commented 4 months ago

For now, the build would fail because of a font dependency missing.

Should be fixed (see cause here : https://github.com/microsoft/playwright/issues/13738) by upgrading playwright version (as shown in this fork: https://github.com/marc-bouvier-forks/nohello-site/commit/046cb456876188f153b6404544ec9ca9cd9b7f48)

Then, there are 2 snapshot ui test failures caused by changes in some emojis rendering I suppose. I think those 2 snapshot should be approved.