Fixed huge memory leak issue with $popovers

nohros / nsPopover

Popover dialogs for angularjs applications.

MIT License

126 stars 107 forks source link

Fixed huge memory leak issue with $popovers #108

Closed itamark closed 8 years ago

itamark commented 8 years ago

The $popovers array defined outside of the directive, was never cleared when popovers are removed from the DOM.

This causes a huge memory leak in large lists which greatly slows down the application. Since $popovers is actually never used - I removed it entirely. No more memory leaks!

addaleax commented 8 years ago

@nohros Could you publish a new version to npm/etc. with this?

itamark commented 8 years ago

Btw I think I found some more. I'll update you guys when I'm certain.

On Thu, Jan 28, 2016, 6:11 AM Anna Henningsen notifications@github.com wrote:

@nohros https://github.com/nohros Could you publish a new version to npm/etc. with this?

— Reply to this email directly or view it on GitHub https://github.com/nohros/nsPopover/pull/108#issuecomment-175961784.

ghost commented 8 years ago

Just encountered this bug as well - good catch - is a new release planned?

itamark commented 8 years ago

@dsommerville - hey no problem! @nohros - any chance you can publish the new release?