nohros / nsPopover

Popover dialogs for angularjs applications.
MIT License
126 stars 107 forks source link

How about release the 0.6.9 to make the following bug disappear #96

Open xidui opened 9 years ago

xidui commented 9 years ago

TypeError: triangle.css is not a function

I encountered such error, and after I read the source code, I found the error here:

if (triangle) {
              if (placement === 'top' || placement === 'bottom') {
                left = rect.left + rect.width / 2 - left;
                triangle.css('left', left.toString() + 'px');
              } else {
                top = rect.top + rect.height / 2 - top;
                triangle.css('top', top.toString()  + 'px');
              }
            }

triangle can be '[]', which may pass the check of 'if',

I also found that the problem is solved last month but not released. So how about make a release?

By the way 6.9 is my birthday, so I make this issue to ask for the '0.6.9' release ,hahaha~

wescopeland commented 9 years ago

+1

danfitz36 commented 9 years ago

+1

wescopeland commented 9 years ago

@xidui As a temporary solution, in your bower.json file you can reference the latest commit:

"nsPopover": "c444ad0764e2dabe93a1bde1977a2e2a408a7bde"
xidui commented 9 years ago

@wescopeland thank you for your suggestion

MartyIX commented 9 years ago

+1

lukefrake commented 9 years ago

I've spent a good couple of hours looking into this bug.

There is a huge diff between this repo and what comes down from bower

biamacedo commented 7 years ago

+1