nohwnd / Assert

A set of advanced assertions for Pester to simplify how you write tests.
MIT License
101 stars 12 forks source link

Added DataTable Support #33

Closed ili101 closed 5 years ago

ili101 commented 5 years ago

Changes

I use this in my new tests here to compare PSCustomObject and DataTable to known saved Deserialized copies https://github.com/ili101/Join-Object/blob/be771cf904bdce1c74e8fb08409d277f612e5068/Tests/Join-Object.Tests.ps1#L250

nohwnd commented 5 years ago

@ili101 thanks for the changes. It might be better to split changes to encoding+formatting, and other functional changes. That way it's much easier to review.

The module version in the repo should be irrelevant, it's corrected on AppVeyor when the module is published.

ili101 commented 5 years ago

@nohwnd Thank you. Initially I did not intended to change anything regarding the encoding. First I was confused way the PowerShellGallery version was 0.9.1 and GitHub was "0.7.1", so I run a diff tool to see what are the changes and got that most of the files was "Changed" but not really as that was only the encoding. So I converted both versions encoding and realized that they are all the same and continued from there.

To prevent confusion I recommend that you set the version in GitHub to something like: ModuleVersion = '0.0.0'

Also It looks like AppVeyor clones all text files to Unix style after someone requested it back in 2014 (and broke a lot of people test as consistence) https://help.appveyor.com/discussions/problems/671-coreautocrlf. you can revert this behavior by removing the extra Git configuration in your AppVeyor config so the files will be cloned and published in Windows format: In appveyor.yml

init:
- git config --global --unset core.autocrlf

Or if you don't use one from there Website Settings > Environment > Init > git config --global --unset core.autocrlf

nohwnd commented 5 years ago

@ili101 allright, thanks, I edited the psd1 and the git config 👍