search

nohy8484568 / workshop2_1105137244

0 stars 0 forks source link

[CodeReview]-Coding Style & Coding Quality #2

Open GSSBilly opened 5 years ago

GSSBilly commented 5 years ago

良好&有意義註解

[Function] https://github.com/nohy8484568/workshop2_1105137244/blob/b281979f61a79bae826486aa4393efa4950e8888/Workshop2/Views/Books/Index.cshtml#L134

https://github.com/nohy8484568/workshop2_1105137244/blob/b281979f61a79bae826486aa4393efa4950e8888/Workshop2/Views/Books/Index.cshtml#L151

https://github.com/nohy8484568/workshop2_1105137244/blob/b281979f61a79bae826486aa4393efa4950e8888/Workshop2/Controllers/BooksController.cs#L33

GSSBilly commented 5 years ago

函數、變數、屬性存在的合理性

[請明確指定 class，不需要就不要放] https://github.com/nohy8484568/workshop2_1105137244/blob/b281979f61a79bae826486aa4393efa4950e8888/Workshop2/Views/Books/Index.cshtml#L22

GSSBilly commented 5 years ago

一致性

[htmlAttributes，具名參數使用與否請維持一致性]

https://github.com/nohy8484568/workshop2_1105137244/blob/b281979f61a79bae826486aa4393efa4950e8888/Workshop2/Views/Books/Index.cshtml#L54

https://github.com/nohy8484568/workshop2_1105137244/blob/b281979f61a79bae826486aa4393efa4950e8888/Workshop2/Views/Books/Index.cshtml#L81

GSSBilly commented 5 years ago

冗餘檔案

[未使用的 View] https://github.com/nohy8484568/workshop2_1105137244/blob/b281979f61a79bae826486aa4393efa4950e8888/Workshop2/Views/Books/Search.cshtml#L1-L141

https://github.com/nohy8484568/workshop2_1105137244/blob/b281979f61a79bae826486aa4393efa4950e8888/Workshop2/Views/Books/SearchResult.cshtml#L1-L86

GSSBilly commented 5 years ago

DRY 原則(Do not repeat yourself)

[重複的 Style 設定， 請善用 Layout] Index, Create......等等 https://github.com/nohy8484568/workshop2_1105137244/blob/b281979f61a79bae826486aa4393efa4950e8888/Workshop2/Views/Books/Index.cshtml#L8-L12

https://github.com/nohy8484568/workshop2_1105137244/blob/b281979f61a79bae826486aa4393efa4950e8888/Workshop2/Views/Books/Create.cshtml#L86-L88

GSSBilly commented 5 years ago

命名原則

[使用有意義命名] https://github.com/nohy8484568/workshop2_1105137244/blob/b281979f61a79bae826486aa4393efa4950e8888/Workshop2/Controllers/BooksController.cs#L18

[公共私有變數大小寫區分] https://github.com/nohy8484568/workshop2_1105137244/blob/b281979f61a79bae826486aa4393efa4950e8888/Workshop2/Models/Service/BooksService.cs#L74