noi-techpark / bdp-commons

Open Data Hub time series data collectors (legacy)
GNU Affero General Public License v3.0
2 stars 12 forks source link

As a traffic analyst I would like to have also air quality measurements taken by the A22 innovative sensors averaged on 60 minutes #244

Closed rcavaliere closed 3 years ago

rcavaliere commented 3 years ago

Elaboration was already implemented, but in relation to bug fix related to the issue #236 it is likely that this elaboration was corrupted or disabled.

bertolla commented 3 years ago

Who is calculating this averages? Is it a different dc? Can you point to the dc which is handling this task?

rcavaliere commented 3 years ago

I think it is the same DC, can you please check?

bertolla commented 3 years ago

It's not the same. It's a java application created to execute this task. See https://github.com/noi-techpark/bdp-elaborations/tree/master/airquality-elaborations

bertolla commented 3 years ago

I updated all dependencies and redeployed the application. Seems to work now. Can you confirm?

rcavaliere commented 3 years ago

Yes, seems to work! Let's leave this user story in testing for a while so to see the behavior for a couple of days

rcavaliere commented 3 years ago

@bertolla can we improve the logic so to have the latest 60-minutes averages fast real-time? E.g. make the computation soon after the 00:00

bertolla commented 3 years ago

This is not yet working as expected. Data is not always up to date and some types/stations are not being calculated. This is due to long intervals of no data and insufficient data (we have set a minimum of 30 datapoints to do average calculations).