A22 Parking DC should not have (if not necessary) the types "free" and "occupied"

noi-techpark / bdp-commons

GNU Affero General Public License v3.0

2 stars 12 forks source link

A22 Parking DC should not have (if not necessary) the types "free" and "occupied" #490

Open rcavaliere opened 2 years ago

rcavaliere commented 2 years ago

I don't know why, but A22 parking areas have now as types "free" and "occupied". At present, A22 provides the information "occupied" only for a parking area (Sadobre), for the others we just receive a state. Please have a look at the attached specifications. 210813_SpecificheIntegrazione_A22_Parcheggi_v2.pdf

dulvui commented 2 years ago

I checked the datacollector and it calculates the occupied value with "capacity - free", so it doesn't use a value from A22 but calculates it on its own. Should I remove this state or should i leave it as it is?

rcavaliere commented 2 years ago

@dulvui the point is that the type "free" should not be associated to these parking areas. So, if you correct this, the automatic elaboration for the "occupied" type should be automatically fixed.

rcavaliere commented 2 years ago

@dulvui I think we should proceed here as follows:

[x] control which parking areas coming from the A22 Parking Data Collector have the "free" (or "occupied") type
[x] for all parking areas which do not have the "free" (or "occupied") type, delete the time series in production and testing environments referred to these types
[x] ensure that the automatic elaboration which computes the free parking areas (or occupied) based on the capacity does only consider parking areas that have this type associated

dulvui commented 2 years ago

@rcavaliere I can confirm that Sadobre is the only station with 'free' data-type associated. All other stations will no longer have an entry in measurements table, only the capacity in the stations metadata will be available. Should I delete also the timeseries data in measurements history?

rcavaliere commented 2 years ago

@dulvui exact. Yes please, delete all historical data for the parking stations that do not have free / occupied.

dulvui commented 2 years ago

@rcavaliere The updated dc is now running on testing and all data, including history is deleted there. I checked the parking elaborations and they should ignore now the stations with no occupied/free type.

In the testing database i only find now the stations Sadobre with this types. I just don't understand why I can't find the A22 parking stations in the /latest request (in production I should find all and on testing only Sadobre): https://mobility.api.opendatahub.bz.it/v2/flat,node/ParkingStation/*/latest?limit=-1&where=sorigin.eq.A22 https://mobility.api.opendatahub.testingmachine.eu/v2/flat,node/ParkingStation/*/latest?limit=-1&where=sorigin.eq.A22

rcavaliere commented 2 years ago

@dulvui I see the improvement already in the production environment, is this possible? However, this is the expected behaviour, so in my view the issue is solved. If this is already applied in production, the result of your query to /latest is correct.

dulvui commented 2 years ago

@rcavaliere Yes I deployed yesterday afternoon to production. Okay awesome!