noi-techpark / bdp-commons

Open Data Hub time series data collectors (legacy)
GNU Affero General Public License v3.0
2 stars 12 forks source link

As a traffic events Data Consumer I would like to see all A22 traffic events that are also visible on the A22 web site (and much more)! #600

Open rcavaliere opened 1 year ago

rcavaliere commented 1 year ago

I am not sure that we are retrieving all A22 traffic events.

Check for example this situation: current events on the A22 highway (A22 web site, https://www.autobrennero.it/it/)

Screenshot from 2022-12-23 11-54-50

And current events retrieved from the Open Data Hub (analytics test version, with events included):

Screenshot from 2022-12-23 11-55-43

We should check if this event highlighted on the A22 web site is also provided through their web-service.

Results of the internal session with @dulvui on 27.04.2023:

rcavaliere commented 1 year ago

@dulvui I have checked a little bit this morning. I think we need to check the Data Collector. I have seen at least two issues:

It could also be that we have a data quality issue, but we have to investigate this. We need some detailed analysis here by comparing data made available through the A22 API - data stored in the Open Data Hub - data visualized on analytics. In case, let's take some time together for these tests...

dulvui commented 1 year ago

@rcavaliere The duration of the events is now shown correctly. It was shown in AM/PM format, instead of 24H format

rcavaliere commented 1 year ago

@dulvui yes, this looks OK now. We have here now to understand if we are receiving all data from the A22 web-service. I would in particular check if events of certain categories like queues, accidents or similar, which are shown on the A22 information channels are provided through the web-service or not. More specific: try to make some curl requests to the A22 web-service and check if this is consistent with the data we integrated. If yes, I will contact A22 and better explain this. If no, we need to understand where the issue in the Data Collector is.

dulvui commented 1 year ago

@rcavaliere I saw now in the logs, that some events have now a new 'idsottotipoevento' that is not present in the sottotipi csv https://github.com/noi-techpark/bdp-commons/blob/main/data-collectors/event-a22/src/main/resources/it/bz/noi/a22/events/SottotipiEventi.csv This is happening since 07.04.2023, so it is not correlated to the events we are currently missing. I'm still investigating on the missing events.

Here the list of the new 'idsottotipoevento' ids:

A22:BrennerLEC_idsottotipoevento:229
A22:BrennerLEC_idsottotipoevento:230
A22:BrennerLEC_idsottotipoevento:233
A22:BrennerLEC_idsottotipoevento:234
A22:BrennerLEC_idsottotipoevento:236
A22:BrennerLEC_idsottotipoevento:237
A22:BrennerLEC_idsottotipoevento:240
A22:BrennerLEC_idsottotipoevento:241
A22:BrennerLEC_idsottotipoevento:244
A22:BrennerLEC_idsottotipoevento:245
A22:BrennerLEC_idsottotipoevento:249
A22:BrennerLEC_idsottotipoevento:250
A22:BrennerLEC_idsottotipoevento:253
A22:BrennerLEC_idsottotipoevento:254
A22:BrennerLEC_idsottotipoevento:256
A22:BrennerLEC_idsottotipoevento:257
A22:BrennerLEC_idsottotipoevento:260
A22:BrennerLEC_idsottotipoevento:264
A22:idtipoevento:26_idsottotipoevento:225
A22:idtipoevento:26_idsottotipoevento:226
rcavaliere commented 1 year ago

@dulvui yes, I am aware of this and this mainly related to the fact that the variable speed limits of BrennerLEC have been extended to other sections of the A22 and they have prepared new standard events template for them when activated. I will ask A22 to give us their explanation so to update the descriptions in our CSV file

dulvui commented 1 year ago

@rcavaliere I saw now that some events have the same start and end date in the interval. The method that checks if a event is valid doesn't allow to have start and end date the same. I added now +1 second to the end if they are the same on testing, so this problem should not happen anymore. I checked on the writer side and changing it to accept an interval with start = end is not possible. For now it is live in testing. Next week we can check, if we get now the missing events.

rcavaliere commented 1 year ago

@dulvui I am still skeptical that we do not receive or handle all events. Let's try next week to make together some calls to the API of A22, and let's see what we get.

rcavaliere commented 1 year ago

Results of the internal session with @dulvui:

rcavaliere commented 1 year ago

Discussion on-going with A22 in order to get ALL event categories (should not be a problem)