noi-techpark / bz-parking-angular

angular client code for parking.bz.it
https://www.parking.bz.it
0 stars 1 forks source link

Updated version of the bz-parking-app #14

Closed mwallnoefer closed 2 years ago

mwallnoefer commented 2 years ago

Improved version of the bz-parking-app created by the two TFO BZ students Philipp Piovesan and Christian Liso.

Please merge!

Piiit commented 2 years ago

@mwallnoefer Hi, and thanks for this contribution also to the two students. It is very nice to see, that students improve our projects :-D

May I ask you to remove the node_modules you added?

Let me know if you have any question. In the meantime I will mark this PR as draft...

Cheers, Peter

mwallnoefer commented 2 years ago

Hallo Peter,

habe dich nicht ganz verstanden, es ist nicht ganz leicht, nur über Text miteinander zu interagieren.

Meintest du diese Abhängigkeiten in der package.json zu löschen und dann _nodemodules zu leeren?:

    "tsc": "^1.20150623.0",
    "typescript": "^4.1.3"

Oder gar nur _nodemodules zu leeren, so dass ihr es auf dem Server neu erzeugt?

Piiit commented 2 years ago

Hi @mwallnoefer , what I mean is to remove the node_modules folder completely and put it into a .gitignore file...

Secondly, we still need to create a staging environment to test these changes properly, so that might be at the beginning of next year.

Thanks again and merry xmas!

mwallnoefer commented 2 years ago

Hi @mwallnoefer , what I mean is to remove the node_modules folder completely and put it into a .gitignore file...

done

Secondly, we still need to create a staging environment to test these changes properly, so that might be at the beginning of next year.

Thanks again and merry xmas!