search

noi-techpark / it.bz.beacon.api

This repository contains the sourcecode of the administration web-app that allows to manage the beacon network installed withing the Beacon Suedtirol project.
Other
1 stars 3 forks source link

Status "No Signal" wrong #60

Closed sseppi closed 3 years ago

sseppi commented 4 years ago

By using the Admin App I've noticed that the API returns "NO SIGNAL" when a beacon has been seen in the last 12 months. This is the opposite way like it should be.

sseppi commented 4 years ago

Investigating a little bit more the problem I think that the bug is in the following point of the code:

https://github.com/noi-techpark/beacon-suedtirol-api/blob/master/src/main/java/it/bz/beacon/api/model/Beacon.java#L310

I think that the right code should be:

if (!hasRecentlySeen()) {
    return Status.NO_SIGNAL;
}

@davidebz can you please check this bug?

Piiit commented 4 years ago

Seems to be an issue, that is better solved by @davidebz ... I had a look into that and it looks like Davide touched that part of the code in the past.

davidebz commented 4 years ago

Investigating a little bit more the problem I think that the bug is in the following point of the code:

https://github.com/noi-techpark/beacon-suedtirol-api/blob/master/src/main/java/it/bz/beacon/api/model/Beacon.java#L310

I think that the right code should be:

if (!hasRecentlySeen()) {
    return Status.NO_SIGNAL;
}

@davidebz can you please check this bug?

Yes, Thomas confirm me that the not (!) was missing!

Piiit commented 4 years ago

Done by @sseppi https://api.beacon.testingmachine.eu/swagger-ui.html

@davidebz please test on testingmachine...

Piiit commented 3 years ago

We need to wait for the new version of the Admin Android app... Google has it still in review...