noi-techpark / it.bz.noi.community.android

NOI Community App for Android
GNU General Public License v3.0
1 stars 1 forks source link

Integrate firebase crashlytics #56

Closed matax87 closed 3 years ago

Piiit commented 3 years ago

@matax87 The 5-tap trick on the NOI logo inside "More" works, app crashes... but even after 10 minutes I do not see a crash report on Firebase

chiaraDimension commented 3 years ago

@matax87 The 5-tap trick on the NOI logo inside "More" works, app crashes... but even after 10 minutes I do not see a crash report on Firebase

@Piiit did you build in debug mode via CD maybe?

Piiit commented 3 years ago

@chiaraDimension I build with ./gradlew bundleRelease... I tried to put some println into build.gradle as follows:

    buildTypes {
        release {
            println "!! RELEASE !!"
            minifyEnabled true
            proguardFiles getDefaultProguardFile('proguard-android-optimize.txt'), 'proguard-rules.pro'
            enableGoogleServices = true
        }
        debug {
            println "!! DEBUG !!"
            enableGoogleServices = false
        }
    }
...
println "GOOGLE SERVICES ENABLED? " + enableGoogleServices

The output was:

$ ./gradlew bundleRelease

> Configure project :app
!! RELEASE !!
!! DEBUG !!
GOOGLE SERVICES ENABLED? false
Piiit commented 3 years ago

Please have a look, I move it back to TODO

chiaraDimension commented 3 years ago

@Piiit google-services were disabled both in debug and release. We fixed build.gradle file to disabled them only in debug mode. We also removed the build step from unit_tests job of CI, because it was not necessary and made into problems with google-services as well.

When you'll merge PR #68, try to force another crash and check if it appear on Firebase console, please.

Piiit commented 3 years ago

@chiaraDimension Perfect, thanks... I will test and let you know

Piiit commented 3 years ago

@chiaraDimension CI fails... https://github.com/noi-techpark/it.bz.noi.community.android/runs/4093743031?check_suite_focus=true

chiaraDimension commented 3 years ago

@chiaraDimension CI fails... https://github.com/noi-techpark/it.bz.noi.community.android/runs/4093743031?check_suite_focus=true

Sorry, we missed to restore google-services.json injection step (see PR #69 )