noi-techpark / it.bz.opendatahub.databrowser

Explore and navigate through Open Data you need to build your next service.
https://databrowser.opendatahub.com
GNU Affero General Public License v3.0
9 stars 7 forks source link

As a Open Data Hub Data Browser user I want a new icon for missing images, to better understand that there are no images. #300

Closed sseppi closed 1 year ago

sseppi commented 1 year ago

I share here two examples of possible placeholder icons/image that can be used as reference in the definition of the new icon.

Image Image

pkritzinger commented 1 year ago

There's not enough space for the text since the space for the image is too small. We've changed the icon, looking forward to your feedback. @sseppi

Image

sseppi commented 1 year ago

@pkritzinger i assume that the problem is for small devices. Can you please share a screenshot of the entire Data Browser or the link to the Figma file where I can see the entire Table View with the icon? It would be really helpful to understand if the direction is the right one.

@mrabans what do you think?

mrabans commented 1 year ago

@sseppi @pkritzinger a red cross in general indicates there is something wrong or someone has to stop. This is a harsh symbol for showing that there no image. We might use this placeholder in cases where there cannot be any image because it's maybe a sensor and there is an icon attribute.

To have a more general icon (outside of the tourism domain) I'd remove the red cross and work with black/white/grey.

pkritzinger commented 1 year ago

See proposal here:

https://www.figma.com/file/DmuP6Dbv5LzkCNOXrDnWIL/2023?node-id=8%3A3324&t=kZTFyhuvfbX1sTJ8-1

sseppi commented 1 year ago

@pkritzinger I had a look to the icons with part of the team and the most liked icon to use as placeholder is the fourth one.

@mrabans what is your opinion?

mrabans commented 1 year ago

@pkritzinger @sseppi same. Looking at it in two different occasions the fourth is my favorite

gappc commented 1 year ago

I also like number four but is it clear from the placeholder that an image is missing? Anyway, after we have a final decision, @pkritzinger, @Mazzolintis: please provide a way to export the icon as SVG, like for all the icons before

sseppi commented 1 year ago

I shared the Figma internally and nearly all people prefers the 4th one. So I would say let go on with the fourth one.

pkritzinger commented 1 year ago

placeholder-odh-databrowser

@gappc find SVG here. Are you not able to export the files from Figma? Pls. let me know, in case we should have a look at it together.

gappc commented 1 year ago

@pkritzinger thank you. Usually in Figma I'm able to select the icons as a whole and export them as SVG, but for some icons (like the current one) failed - probably I'm missing something.

pkritzinger commented 1 year ago

@gappc ok, lets discuss next time in the meeting.

gappc commented 1 year ago

@sseppi, @mrabans, @pkritzinger: done as of a59758724dd5c7d5f9b4a62001618bbea8d40d24, you can take a look here: https://databrowser.opendatahub.testingmachine.eu/dataset/table/tourism/v1/ODHActivityPoi.

If it's ok, please close the issue

pkritzinger commented 1 year ago

can be closed from my point of view @sseppi

sseppi commented 1 year ago

The issue can be closed also from my point of view.