general checks and improvements

[d3liaa]

Hi Christian, i made an overall check and adjusted some things. For example:

• Logo to big in detail view ->i put the width undefined in the component to make it adjustable in the detail view but left 100% for the edit view
• fixed municipalityIdcell -> it showed a dropdown instead of the id

[gappc]

Hi @d3liaa, thank you for the PR. Since there are a lot of changes, I'd like to have a meeting with you to take a look at the changes together. It would probably be a good idea to have @pkritzinger and @RudiThoeni in the meeting as well. I'll write an email

[d3liaa]

Yes of course! I will be available from the first of march onwards!

Have a nice weekend, Delia :)

Il giorno sab 25 feb 2023 alle 13:21 gappc @.***> ha scritto:

Hi @d3liaa https://github.com/d3liaa, thank you for the PR. Since there are a lot of changes, I'd like to have a meeting with you to take a look at the changes together. It would probably be a good idea to have @pkritzinger https://github.com/pkritzinger and @RudiThoeni https://github.com/RudiThoeni in the meeting as well. I'll write an email

— Reply to this email directly, view it on GitHub https://github.com/noi-techpark/it.bz.opendatahub.databrowser/pull/310#issuecomment-1445087461, or unsubscribe https://github.com/notifications/unsubscribe-auth/AYDPAQOXRFVFW2HWELUCMV3WZH2LBANCNFSM6AAAAAAVFWRB5E . You are receiving this because you were mentioned.Message ID: @.*** com>

[sseppi]

@gappc please invite me at the meeting, I will add then Rudi in case of need.

[gappc]

@sseppi yes I can invite you, but we need to wait for Delia.

[gappc]

@d3liaa I saw that your branch has merge conflicts. Please solve them. Further, please note that you should not change Article and EventShort, because those two are already ready.

Thank you

[d3liaa]

Understood! I will fix everything as soon as I get back! Have a nice day, Delia:)

Il giorno lun 27 feb 2023 alle 09:04 gappc @.***> ha scritto:

@d3liaa https://github.com/d3liaa I saw that your branch has merge conflicts. Please solve them. Further, please note that you should not change Article and EventShort, because those two are already ready.

Thank you

— Reply to this email directly, view it on GitHub https://github.com/noi-techpark/it.bz.opendatahub.databrowser/pull/310#issuecomment-1445872763, or unsubscribe https://github.com/notifications/unsubscribe-auth/AYDPAQL46FICWAMVNWGIPODWZRNY7ANCNFSM6AAAAAAVFWRB5E . You are receiving this because you were mentioned.Message ID: @.*** com>

[gappc]

Hi @d3liaa, do you have updates regarding this PR?

[d3liaa]

Hi @gappc i was waiting for your return, so we could continue the meeting and finish analyzing the PR together. Do you want to schedule a meeting?

[gappc]

@d3liaa yes, lets schedule a meeting, I'll write you an email