noi-techpark / it.bz.opendatahub.databrowser

Explore and navigate through Open Data you need to build your next service.
https://databrowser.opendatahub.com
GNU Affero General Public License v3.0
9 stars 7 forks source link

As an Open Data Hub Data Browser developer I want an API that allows me to get/modify/add all publishers to automatically populate the "published on" component #317

Closed sseppi closed 1 year ago

sseppi commented 1 year ago

To allow the use a standard TAG component to render and modify the "Published on" information in the data browser we need to extend the APIs with the following functionality:

deadline: 15 May 2023

sseppi commented 1 year ago

@RudiThoeni : do you see potential risk in giving the possibility to modify and delete existing publishers?

RudiThoeni commented 1 year ago

the risk is always there but i think we will give the rights of publisher management only to certain people.... But i think we can add some restrictions maybe to not let change the "id/key" of any publisher because here the problem is more about the documentDB Design of the Database....... when a key is changed all assigned keys on any objects will become orphaned....

sseppi commented 1 year ago

@RudiThoeni thank you for sharing your opinion.

So fine for me to proceed as you proposed.

gappc commented 1 year ago

@RudiThoeni as far as I understand, the API exists (see generated view in Data Browser here: https://databrowser.opendatahub.testingmachine.eu/dataset/table/tourism/v1/Publisher). Is that correct?

@sseppi if the API exists, should we define an embedded view (aka file in git) for the Data Browser such that it can be edited through the Data Browser (please note: at the moment, generated views don't support editing)?

sseppi commented 1 year ago

@gappc yes the API has been implemented by Rudi and updated with CRUD functionality.

If it is not a big effort, you can configure also the Edit view for this Dataset. In the issue #318 we should then focus on how simplify the process of adding a new TAG/publisher in general.

gappc commented 1 year ago

@sseppi it's not a big effort, I'll put it on my TODO list and let you know when it's done

gappc commented 1 year ago

@sseppi @RudiThoeni : config is done as of 92b8241bcea76ea834c2893d6651fe6248cd5a91. Please note that I forgot to include the "Name" field in the Detail- and EditView. I added it now, it should be deployed in a couple of minutes.

You can take a look at it here:

Please take a look at it and close this issue if it's OK.

gappc commented 1 year ago

@sseppi can we close this issue?

sseppi commented 1 year ago

Yes, I thought it was already closed... Probably I forgot to do it. ;-)