noi-techpark / it.bz.opendatahub.databrowser

Explore and navigate through Open Data you need to build your next service.
https://databrowser.opendatahub.com
GNU Affero General Public License v3.0
9 stars 7 forks source link

As a databrowser editor i want to edit the json directly if i have the Role "JsonEditor" assigned #334

Open RudiThoeni opened 1 year ago

gappc commented 1 year ago

@RudiThoeni I took a look at possible solutions:

The vue-json-pretty has not enough features (very limited set of edit capabilities), so in my opinion it is not the right choice.

monaco is a great editor, but it has a huge foodprint (1.1MB zipped) and it is not mobile friendly.

Finally, codemirror seems to be the best fit for the purpose, but it also increases the download volume. If this is acceptable, I'd opt for codemirror.

@RudiThoeni @sseppi what are your opinions?

sseppi commented 1 year ago

Since for Patrick is important that the Data Browser works also on mobile, I agree that monaco isn't the right choice.

Probably codemirror is the best option, if vue-json.pretty hasn't all the edit capabilities we need.

@gappc since we have a lot of work already planned in the Milestone 2.2 (the next one), shall we program the implementation of this functionality in the Milestone 2.3?

gappc commented 1 year ago

@sseppi yes, I'd move it to Milestone 2.3 or even later, as this is a nice-to-have functionality that will be used only by a very few users. @RudiThoeni do you agree or do you think we should prioritize it more?

RudiThoeni commented 1 year ago

fine for me!

sseppi commented 1 year ago

OK, so let keep it in the Milestone 2.3 and then take the final decision at the beginning of the Milestone development when we decide all the functionalities will be implemented in the iteration.