noi-techpark / it.bz.opendatahub.databrowser

Explore and navigate through Open Data you need to build your next service.
https://databrowser.opendatahub.com
GNU Affero General Public License v3.0
9 stars 7 forks source link

The “Add a record” does not work from Table View and Detail View #340

Closed sseppi closed 1 year ago

sseppi commented 1 year ago

As explained by Chiara for some datasets, the Add a record button doesn't work from the Table View, the Raw View and the Detail View.

More details are available in the slide 2, 3, 4 and 5 of the presentation at the following link: https://docs.google.com/presentation/d/1rHV6uue1r8hk_tQD2Q0KFRPI6w8alPld9n6mUnnPSdE/edit?usp=sharing

gappc commented 1 year ago

@sseppi I cannot access the slides, could you please send them to me?

sseppi commented 1 year ago

@gappc now you should have access to the shared document.

gappc commented 1 year ago

@sseppi yes, now it works :+1:

gappc commented 1 year ago

@sseppi there was a bug that was fixed in 51b3cc60, the "Add a record" button was shown even if no NewView existed.

Below you find the new checks. The "Add a record" button will only be displayed if all of them are met:

Since we have never discussed how adding a new record should behave (what is there at the moment is just some proof of concept on my behalf), maybe this issue can be used as a start to get that feature implemented fully.

In essence the idea is to have a trimmed-down version of the EditView of a dataset with only the fields necessary to add a new entry. Note that it is also possible and feasible to just reuse the EditView to add a new dataset, but for some EditViews the required fields are distributed among different categories, which makes adding a new record clumsy.

sseppi commented 1 year ago

During the sprint meeting we decided to reuse the Edit View to create a new record.

In case of need we will the decide how to improve the "Add new record" functionality on top of the feedback provided by the users.

d3liaa commented 1 year ago

Datasets were the new record is implemented:

sseppi commented 1 year ago

Top!

I reviewd the list with Rudi that agrees.

Thank you @d3liaa

@gappc I think we are ready to move the issue in the review lane?

gappc commented 1 year ago

@sseppi @d3liaa I think the config changes have still to be done, is that correct?

d3liaa commented 1 year ago

I did them I only have to push it. I’ll do it ASAP

gappc commented 1 year ago

@d3liaa @sseppi PR is merged as of fce9fd5e92b889d1a8498365b75707dc77db4601, please check and close the ticket if ok.