As an Open Data Hub Editor I want to edit also GPS coordinates, to improve the position of my POIs

[sseppi]

As a first step, I would suggest to implement the possibility to change the GPS coordinates by imputing the Logitude and Latitude and other information in the proper input fields.

The possibility to change the position by using the map will be postponed to the next iteration and, in case, a dedicated issue will be created.

[sseppi]

@pkritzinger @Mazzolintis we need to discuss this topic during the next meeting, we need to find a way to edit GPS coordinates and then implement it.

[sseppi]

@pkritzinger can you please share the link to the design, you showed during the meeting?

The Altitude field will be set as Read Only in the API and shown as a non editable field in the Data Browser. We need to remove the drop-down icon.

For the GPS-Type the component drop-down+freetext will be used. The first GPS inserted per default will be GPS-Type = position. This aspect will be further clarified with Rudi.

[pkritzinger]

@sseppi find the link here:

https://www.figma.com/file/DmuP6Dbv5LzkCNOXrDnWIL/2023?type=design&node-id=1502%3A9766&mode=design&t=Ha38KlFfOl45aW1j-1

[sseppi]

@pkritzinger thank you!

[sseppi]

@MatteoBiasi @gappc

Me and Martin had a talk with Rudi about the Gpstype field and the outcome was the following.

We decided to keep using only the GpsInfo attribute and deprecate the GpsPoints since the first one is more easy to use and understand for the API consumers.

Considering this decision, to render and populate the GPS coordinates of an element, we should use only the GpsInfo attribute and the Open Data Hub will then sync the data also in the GpsPoints deprecated attribute. This means that the Gpstype field becomes optional and in case that the user does not populate it the Open Data Hub will assign a default Gpstype while he does the Sync between GpsInfo and GpsPoints attribute.

[gappc]

@sseppi @RudiThoeni to clearify, you mean the GpsInfo array, that contains GPS objects? Is Gpstype then optional?

@sseppi could you please update the other issues, so we have one single decision that is valid for all issues?

[RudiThoeni]

is it possible to have a short call monday/Tuesday next week where we clarify this definitely?

[sseppi]

@gappc would it be possible for you to have a short call monday 30 between 9 and 11 am?

[gappc]

@RudiThoeni @sseppi monday I have time until 10:00, it would be great if we could meet before. Just let me know.

[RudiThoeni]

As mentioned in issue https://github.com/noi-techpark/it.bz.opendatahub.databrowser/issues/435 we will use GpsInfo as the field where GPS Info is stored

[pkritzinger]

@sseppi @gappc @MatteoBiasi we had a look at how big players allow users to individually set a position on the map. Honestly speaking, neither on Google Maps nor on Apple Maps a clear pattern could be found. Sometimes a long-pressed click, sometimes a simple click led to the desired result.

With Google myMaps, we found an interaction pattern that could be a best practice for our needs. We documented it in the following figma file and added our comments. What do you think? If fine for you we can create the design. https://www.figma.com/file/DmuP6Dbv5LzkCNOXrDnWIL/2023?type=design&node-id=1582%3A293&mode=design&t=X8T3f6H4jPBwdGWW-1

[MatteoBiasi]

@pkritzinger thanks for your proposal. By my side I agree that the proposed solution is pretty consistent in terms of UX. On the other site it requires a pretty heavy effort in terms of development, particularly for the pin drag & drop feature. Unless we can find something already done, I believe we need to assess if it's worth it, or if a simple click on the map to set the pin and move it by clicking elsewhere is sufficient. Drag & Drop would become useful if we had more pins, but at the moment, that's not our case.

[pkritzinger]

@MatteoBiasi thanks for your feedback - see your point. Important from my point of view is that we force the user to activate the edit-feature of the pin on the map. Otherwise I am afraid that changing a GPS-Position is done way too easily and mistakes or unwanted actions may occur.

[sseppi]

@MatteoBiasi thanks for your feedback - see your point. Important from my point of view is that we force the user to activate the edit-feature of the pin on the map. Otherwise I am afraid that changing a GPS-Position is done way too easily and mistakes or unwanted actions may occur.

@pkritzinger and @MatteoBiasi thank you for your feedbacks! I get the point of both of you and my considerations, that I would like to discusso tomorrow in the sprint meeting are:

• on mobile I fully agree with Paul that keeping the possibility to change the points with a single tap could lead to mistakes;
• on desktop, considering that to change data the user has to actively activate the edit view, I would avoid that the user has to activate too many edit functionality.

[sseppi]

Since in the future we plan o remove the Edit View and provide the possibility to activate the editing for the single fields, we decided to test this behaviour on the map.

Next Steps

• @pkritzinger will provide the design of a button to activate the editing of the maps that could be used also for the other fields;
• @MatteoBiasi will implement the solution

The map, also in edit mode, will be kapt small and ther will be an icon on the map to open the full screen mode.

[pkritzinger]

@sseppi @MatteoBiasi please find the final design here: https://www.figma.com/file/DmuP6Dbv5LzkCNOXrDnWIL/2023?type=design&node-id=1582%3A293&mode=design&t=a5FLGbJKDv9XUu40-1

Comments describe the behavior of the UI.

[sseppi]

@pkritzinger thank you for the design!

@MatteoBiasi can you please implement also the changes (add the two buttons) on the full screen mode for the images?

[RudiThoeni]

I merged the latest PR @sseppi please test, i let you close the issue.

Very good component, good work 👍 I tested and was able to add/modify gps points on an accommodation and an activity

[sseppi]

I tested the new functionality too, and it seems to work fine. I have only one questo for @pkritzinger.

If I'm in the Edit View in the GPS section and I open the full screen map from the table (see screenshot below)

Wouldn't be better, to open the editable map (screenshot below)? In the actual version online in testing the map without the possibility to change the GPS point get open.

What is your feedback?

[pkritzinger]

@sseppi from my point of view it is fine as it has been implemented, since:

• behavior is the same as for the image-component
• if we changed it to your proposal the behavior of the fullscreen view would be different between edit view and detail view

what i found: in the detail view the user has the possibility to enter the detail of the table where the pin can be moved. This feature should be hidden. Also, by clicking on fullscreen, the map should only be opened in fullscreen without having the possibility to change the position of the pin.

[sseppi]

@pkritzinger thank you for your feedback. About your findings, let discuss it together in the next sprint meeting.

[pkritzinger]

@sseppi I'll probably be able to participate in the call tomorrow. We can discuss it there :)