Venue room

[d3liaa]

Hi @gappc @sseppi @pkritzinger , I noticed that the Venue dataset has a Room Detail Array with useful info that is not displayed. Since the format is practically the same for the Room Booked in the Event Short dataset I created a similar table using that as a template. In the table, I displayed: Shortname, Indoor, and SquareMeters attributes since these seemed the most relevant and easy to show. I inserted this table in the Main Data section after the IDs.

[gappc]

Hi @d3liaa, impressive work, thank you :+1:

Some feedback:

• the "Indoor" value is a boolean (see here). I think this value is better handled by a toggle (e.g ToggleCell)
• the rooms in venue contain other data, like features, detail text, images and many more (take a look at the image below and VenueRoomDetails type in Swagger). @sseppi @pkritzinger @RudiThoeni should we display / add that data? Note that the "old" Data Browser seems also to handle only a subset of the available attritbutes (see here)

[d3liaa]

Thank you!! Then I will wait on your feedback on what to add to the table :) (I just updated the indoor attribute to a toggle)

[gappc]

@d3liaa thank you for the change regarding the toggle, but I meant that a toggle should be used in the EditRoomVenueTab component (see my link above), not in the EditRoomVenueTable like you did in the last commit ;) Please change it in the Tab component, too.

[pkritzinger]

hi @gappc @sseppi @d3liaa @RudiThoeni I have to admit that I do not know which attributes are of relevance here but would suggest to go the "easy" way and show the same as were shown in the "old" databrowser.

Btw: thanks a lot for noticing @d3liaa

[d3liaa]

Perfect thank you for the feedback i will fix it ASAP :)

[d3liaa]

Hi, after looking at the VenueRoomDetail schema the only attributes i could find (other than the ones I already added: shortname, indoor, squaremeter) are SetupType and Capacity. These attributes are taken from VenueTypes endpoint. And i don't really know how to implement this type in a table.

[d3liaa]

Hi, @RudiThoeni i noticed that in the databrowser v1 the attributes of the venue room details are not editable. I am having trouble making the attributes capacityand venueTypeseditable with the components available (we would have to create a custom one), do you think that it is necessary that thery are editable? or even shown at all?

Thank you for your time, Delia:)

[RudiThoeni]

Hi Delia

at the moment it is not needed to have it editable since this data is only imported, but in the future maybe...... showing it would be great....

cheers

Tech Transfer Digital

Rudi Thoeni

T +39 0471 066 673 @.**@.>

NOI Techpark Südtirol / Alto Adige A.-Volta-Straße / Via A. Volta, 13A I-39100 Bozen / Bolzano www.noi.bz.ithttp://www.noi.bz.it/

---

Von: Delia Mennitti @.> Gesendet: Donnerstag, 11. Mai 2023 16:00 An: noi-techpark/it.bz.opendatahub.databrowser @.> Cc: Rudolf Thoeni, NOI @.>; Mention @.> Betreff: Re: [noi-techpark/it.bz.opendatahub.databrowser] Venue room (PR #362)

Hi, @RudiThoenihttps://github.com/RudiThoeni i noticed that in the databrowser v1 the attributes of the venue room details are not editable. I am having trouble making the attributes capacity and venueTypes editable with the components available (we would have to create a custom one), do you think that it is necessary that thery are editable? or even shown at all?

Thank you for your time, Delia:)

— Reply to this email directly, view it on GitHubhttps://github.com/noi-techpark/it.bz.opendatahub.databrowser/pull/362#issuecomment-1544040907, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AHIPJQP3Y5KLKINTHWTWVWDXFTWGPANCNFSM6AAAAAAXPCI6AY. You are receiving this because you were mentioned.Message ID: @.***>

[d3liaa]

As requested I put the attribute capacity and setupType read only :) I think it should be ready for merge now:)

[gappc]

Hi @d3liaa, thank you for your work, it's merged now :+1: