search

noi-techpark / it.bz.opendatahub.databrowser

Explore and navigate through Open Data you need to build your next service.
https://databrowser.opendatahub.com
GNU Affero General Public License v3.0
9 stars 7 forks source link

feat: minor QuickView GUI optimizations #366

Closed MatteoBiasi closed 1 year ago

gappc commented 1 year ago

@MatteoBiasi thank you for the changes.

I have one comment (maybe it's a bug) and there are some compile time warnings (see https://github.com/noi-techpark/it.bz.opendatahub.databrowser/pull/366/files). Please take a look at them, thx.

MatteoBiasi commented 1 year ago

@MatteoBiasi thank you for the changes.

I have one comment (maybe it's a bug) and there are some compile time warnings (see https://github.com/noi-techpark/it.bz.opendatahub.databrowser/pull/366/files). Please take a look at them, thx.

All compile warnings have been fixed. 👍

gappc commented 1 year ago

Hi @MatteoBiasi thank you for the fixes. There remain 4 lint warnings regarding Tailwind class names for opacity, e.g. "Classname 'hover:bg-opacity-90' should be replaced by an opacity suffix (eg. '/90')".

You can see them e.g. in the Files changed section of this PR. I can also confirm that the warnings appear when I run npm run lint using your branch on my local machine.

Could you please take a look at it?

MatteoBiasi commented 1 year ago

@gappc fixed. Strange that husky let me do the commit with those two warnings.

gappc commented 1 year ago

@MatteoBiasi I opened an issue #371 to take a look at husky and its configuration. Thank you for your work :+1: