noi-techpark / it.bz.opendatahub.databrowser

Explore and navigate through Open Data you need to build your next service.
https://databrowser.opendatahub.com
GNU Affero General Public License v3.0
8 stars 7 forks source link

Filtering error: Incorrect Data Filtering with includes #381

Closed lukmay closed 1 year ago

lukmay commented 1 year ago

Device: Desktop Operating System: Windows 11 Browser: Chrome, Firefox Problem Description: The filter includes doesn't return the correct data because the used URL is not in the right format.

Example on Open Data Hub Tags - Dataset:

grafik This filtering gets me on the following page: grafik The URL created by this filtering is this: https://databrowser.opendatahub.testingmachine.eu/dataset/table/tourism/v1/Tag?rawfilter=and(in(PublishedOn,%27idm-marketplace%27))&rawsort=Id

The Issue is that the Data field (in this case, PublishedOn) is not traded like an array. To solve the issue manually, we can add .[*] to it.

So the URL should look like this to work: https://databrowser.opendatahub.testingmachine.eu/dataset/table/tourism/v1/Tag?rawfilter=and(in(PublishedOn.[*],%27idm-marketplace%27))&rawsort=Id

gappc commented 1 year ago

@lukmay thank you for the bug report, it should be fixed as of 9bc2d2a10ff23a46c96ba2fa0b98bf9c89fa52ff

@sseppi if it's ok, please close the issue.

sseppi commented 1 year ago

@gappc thank you now it seems to work fine. How would you suggest to put this bugfix in production, alias beta version? Since this issue comes from a feedback of an external user that started to use the Data Browser beta, I would like to go online with the bugfix as soon as possible.

gappc commented 1 year ago

@sseppi I would just release the current version (merge development branch into main branch) as usual.

sseppi commented 1 year ago

@gappc OK, I would do so. Can you please notify me and @lukmay as soon as the bugfix is in production. So we can answer to the customer who opened the ticket?

gappc commented 1 year ago

@sseppi @lukmay the changes are now in production

sseppi commented 1 year ago

Top! Thank you all for the nice work! @lukmay can you please notify the customer that we solved the bug?

lukmay commented 1 year ago

Thank you @sseppi for the reminder. I already did so^^