Fix prettier linting for windows

[henri-egger]

While adapting the husky pre-commit-hook for windows i noticed that it wouldn't even have been possible for any windows user to commit as prettier doesn't allow crlf end of lines.

I just added a rule to the .eslintrc.json file to allow for those kinds of line endings.

[gappc]

@henri-egger thank you for your PR, here are my comments:

• this PR contains the commits from PR #387 - probably some mistake while branching ;). For this PR here, please apply your changes on the development branch and either force-push to this PR here or provide a new PR
• the pipx stuff seems to be Python related (not Windows), so Python needs to be installed. Nevertheless, nice solution :+1: (may still need some testing, I'm not sure)
• the end-of-line problems are already mentioned in this issue: #345; please provide a separate PR for this problem and link it to the mentioned PR. Please also note that your solution depends on prettier being installed / available and just skips the check. Anytime a Win user formats a file from a Linux user (and vice versa) e.g. by having "Format on save" enabled in VSCode, a lot of file contents will change, because the opposing line endings change. What about the .gitattributes solution mentioned in #345? Could you check if that one works better? Please be aware that this change may affect all files and future contributions, so we need to be cautious on implementing the solution

As a side node: at the moment we have contributors that use Windows, so it seems to be possible to commit from Windows, maybe you mentioned something different?

[henri-egger]

@gappc yes the reuse commits are put in by accident, i will provide a new clean PR once we have decided on a solution.

According to the official Prettier documentation, it would actually make more sense to create a .gitattributes file containing * text=auto eol=lf. I tried it however, following the exact steps mentioned here and couldn't get this solution to work.

You mentioned there are already Widows users working on the project, i believe however that they are using WSL as that is very common for Windows users doing web development, can you confirm this? Also i tried doing a clean clone of the repo on Windows without wsl and i was not able to commit due to the prettier linting, so even if some people are already working on Windows which might have found a personal solution, new Windows contributors still have this problem.

[gappc]

@henri-egger thank you for the feedback.

You mentioned, that the .gitattributes solution did not work, what was the problem? Reading through the link you provided, it seems that the line-ending problem should be solvable by these configurations. It would be great if you could take a second look at it.

If I may ask you another favor: could you please put your comments and current knowledge (problems, solutions, links) regarding the line-ending problem from this PR to issue #390 such that we can keep discussing there? I think that would be the appropriate place and the info won't get lost. Thx :)

[henri-egger]

@gappc i will try to take a closer look and move the discussion, did you mean to link issue #345 or would you like me to create a new issue #390?