search

noi-techpark / it.bz.opendatahub.databrowser

Explore and navigate through Open Data you need to build your next service.
https://databrowser.opendatahub.com
GNU Affero General Public License v3.0
8 stars 7 forks source link

Feat/new fields metadata #432

Closed a-crea closed 8 months ago

a-crea commented 8 months ago

This pull request includes the new metadata fields in list view, detail view, new and edit views. It also contains the new functionality to "ADD NEW" value to existing options.

gappc commented 8 months ago

@a-crea thank you for this PR.

Given that the PR changes 66 files, I took a deeper look at it. It seems, that most modifications should not be part of this PR and are related to other work - maybe PR #431 or even PR #429?

I would appreciate if you could clean up this PR and provide only the changes necessary for this PR to fulfill its requirements. Otherwise it gets really hard for me to do a proper review

thx

a-crea commented 8 months ago

@gappc Hi! I have rebased both this PR and #431.

This PR should address #416. Shouldn't we take into account both the new input and the new fields in this PR? I believe it was already treated as a "bundle" since the two features are interconnected.

gappc commented 8 months ago

@a-crea thank you for your effort, but still it seems that something is odd.

If you take a look at the number of files this PR wants to merge on the top right of this page, you'll see that 78 files wait to be merged. I'm pretty sure that most of those files do not belong to this PR. I also tested to merge this PR locally (on my machine) into the current development branch, which resulted in at least one merge conflict (file .github/workflows/main.yml).

Would it be possible for you to open a new PR where you apply your changes (and only those)? I think that would be the easiest way to go forward.

thx

a-crea commented 8 months ago

@gappc Hi! It should be fixed on both PRs. Let me know if everything is good. Thanks!

gappc commented 8 months ago

@a-crea thank you for the computed import-fix, now please fix the build issue (https://github.com/noi-techpark/it.bz.opendatahub.databrowser/pull/432/files/30370103e87ba0b423f7dafa967e3685cf889cb7#diff-c700510ba9aafb210658d4b70f9db4320d846d0b1f47e9dba6e90b7bc3c4eb96) and then I'll be able to merge this PR

a-crea commented 8 months ago

@gappc done, let me know :)

gappc commented 8 months ago

@a-crea I've merged this PR, thx for your work :+1: