noi-techpark / it.bz.opendatahub.databrowser

Explore and navigate through Open Data you need to build your next service.
https://databrowser.opendatahub.com
GNU Affero General Public License v3.0
8 stars 7 forks source link

Make GpsInfo the source of truth for GPS data #435

Closed gappc closed 5 months ago

gappc commented 8 months ago

Note: this issue was created as followup to issue #425 and its comment https://github.com/noi-techpark/it.bz.opendatahub.databrowser/issues/425#issuecomment-1770993493

We defined on our meeting:

In future GpsPoints will be the Property to read and write.

  • A component will be created for GpsPoints where more GPS Points can be added, we have to ensure that the key "position" is always present

Rudi informs the team when the root field GpsPoints is set from readonly to writeable. All other root fields (flat >Latitude,Longitude....... GpsInfo etc...) will be set to readonly

30/10/2023 We defined on our meeting:

In future GpsInfo will be the Property to read and write.

Rudi informs the team when the root field GpsInfo is set for all datasets. All other root fields (flat Latitude,Longitude....... GpsPoints etc...) will be set to readonly.

sseppi commented 8 months ago

@gappc can we move in testing this issue with the changes are merged as of commit https://github.com/noi-techpark/it.bz.opendatahub.databrowser/commit/f3c0bd9cc38e17e1f40dd1662792ccb652d1c92c ? Or do yo need to make further checks?

gappc commented 8 months ago

@sseppi this issue is a followup issue on #425

425 is concerned about changes to the WebcamInfo model, while this issue here is concerned about changes to the GpsPoints model. This issue has a dependency on Rudis changes on the backend.

sseppi commented 8 months ago

OK, everything clear to me! @gappc Thank you for the explanation.

sseppi commented 8 months ago

@gappc @RudiThoeni

As emerged in issue #360 this week emerged a critical aspect in using GpsPointsas source of truth per GPS coordinates. We probably have to use the GpsInfoinstead.

As mentioned in the issue #360 we propose to have a meeting on Monday 30 October between 9 and 11 am.

sseppi commented 8 months ago

@gappc

Today me and Rudi had the planned meeting and we decided together to use the GpsInfo as source of truth for the GPS data. The decision was made, since the GpsInfo is easier to handle from a Data Provider and front-end point of view.

@RudiThoeni will implement the GpsInfo field in all endpoints and make a sync script between GpsInfo and GpsPoints in order to keep them in sync for a certain period. This means that the GpsType hasn't constraint anymore and can be set freely by the user. Rudi, in case

, will manage it properly in the sync script between GpsInfo and GpsPoints.

The GpsPoints will be set as ReadOnly and marked as deprecated. This means that in the Data Browser the user will have the possibility to modify only the GpsInfo.

RudiThoeni commented 7 months ago

Hi

I added 'GpsInfo' on each Dataset as editable, marked the old props as deprecated and readonly

This is all done on testing, waiting for the Component to insert GpsData

sseppi commented 7 months ago

@RudiThoeni thank you for the update!

@gappc I think you can now update the components and configurations in the Data Browser.

gappc commented 6 months ago

@sseppi @MatteoBiasi is this issue still relevant or are the changes already in place?

sseppi commented 5 months ago

@RudiThoeni from your side the changes and configuration has been concluded?

RudiThoeni commented 5 months ago

From my side all concluded GPS Component seems to work fine