As a Data Browser user I want a header height reduced to the minimum, to have more space for the data.

noi-techpark / it.bz.opendatahub.databrowser

Explore and navigate through Open Data you need to build your next service.

https://databrowser.opendatahub.com

GNU Affero General Public License v3.0

8 stars 7 forks source link

As a Data Browser user I want a header height reduced to the minimum, to have more space for the data. #437

Closed sseppi closed 4 months ago

sseppi commented 8 months ago

@pkritzinger : can you please share the new design proposed?

pkritzinger commented 8 months ago

hi @sseppi Here's the link to the respective section: https://www.figma.com/file/DmuP6Dbv5LzkCNOXrDnWIL/2023?type=design&node-id=1508%3A12031&mode=design&t=Ha38KlFfOl45aW1j-1

Some remarks:

We had to integrate the ODH-Logo in the burger menu on mobile devices. Otherwise it would have been in conflict with the icon of the burger menu.
Shall we also rethink the footer. From our perspective we should remove the ODH-Logo (see Screenshot)

sseppi commented 8 months ago

Hi @pkritzinger, thank you for the proposal. Please find below my answers.

Some remarks:

We had to integrate the ODH-Logo in the burger menu on mobile devices. Otherwise it would have been in conflict with the icon of the burger menu.

Fine for me

Shall we also rethink the footer. From our perspective we should remove the ODH-Logo (see Screenshot)

I agree, the Open Data Hub logo should be removed also in the footer.

pkritzinger commented 8 months ago

@sseppi thanks for your feedback. We made the changes in the file - it's ready to code :)

sseppi commented 8 months ago

@MatteoBiasi now you can start the estimation of the implementation of the changes.

RudiThoeni commented 6 months ago

@sseppi please test for me it seems fine

sseppi commented 6 months ago

@RudiThoeni I tested and it seems fine to me too.

@pkritzinger in your point of view, wouldn't be better to open the How To and Contact links in a new window, since they are externa links?

pkritzinger commented 6 months ago

Agree with @sseppi that we should open the links in a new tab. Further, we suggested to improve the Login/ Register-Logic by means of an icon and an expandable menu. See Screenshot below:

This optimization is not a must but in case there should be additional time it could be added to one of the Project Phases.

sseppi commented 6 months ago

@pkritzinger thank you for the feedback.

@MatteoBiasi can you please fix the two proposals in the comment above (open the two links in ne window and improve the login/register icon).

sseppi commented 5 months ago

@MatteoBiasi while testing I noticed that the boxes in the footer aren't clickable anymore.

If I click on the Open Data Hub box in the center I would like to open in a new window the Open Data Hub website (https://opendatahub.com/). If I click on the NOI box (the right one) I would like to open in a new window the NOI website (https://noi.bz.it/).

Can you fix this problem?

THX

MatteoBiasi commented 5 months ago

@sseppi we added the links; here it's the PR: https://github.com/noi-techpark/it.bz.opendatahub.databrowser/pull/529. PS: this was not a bug introduced by us. You can see here that it was the original implementation of Heniry that was without the links.

sseppi commented 5 months ago

@MatteoBiasi Thank you for the implementation and for checking where the original problem was.