noi-techpark / it.bz.opendatahub.databrowser

Explore and navigate through Open Data you need to build your next service.
https://databrowser.opendatahub.com
GNU Affero General Public License v3.0
9 stars 7 forks source link

Difference between detail/edit view and Add a new record view #439

Closed d3liaa closed 11 months ago

d3liaa commented 11 months ago

The add a record configuration is different from the detail / edit view. The add a record view should be the same as the edit but only blank. I noticed this for example in the article dataset: As is visible in the screenshots below there are two fields that should not be present in the Main Data and the published on is completely missing from the configuration. article-ss article-ss1

@dulvui since you have to touch the code, can you please remove the beta badge hard-coded and apply it in a parametric manner. The goal is to have the following behaviour:

gappc commented 11 months ago

@d3liaa @sseppi yes you are right with your observation.

I checked, and the only two datasets with dedicated configuration for add-a-new-record are Articles and PublishedOn.

If @d3liaa 's assumption is correct (new view should be the same as edit / detail view), the fix is as follows:

This change would be a good starter / project-introduction issue if anyone is interested in.

sseppi commented 11 months ago

@pkritzinger @Mazzolintis In my point of view the "New record" and the "Edit" should be the same for a Dataset. The only difference between the two is that the "New record" is completely empty.

If you don't see any contra, I would suggest to plan to do the changes proposed by Chrsitian.

@gappc do you think that this activity could be a good starting point for Simon to start the introduction to the new Data Browser?

pkritzinger commented 11 months ago

@sseppi fully agree to what you described above. Thanks for brining this topic in @d3liaa

gappc commented 11 months ago

@sseppi yes, it would be a good first issue for Simon :+1:

dulvui commented 11 months ago

@gappc @sseppi Both issues are now fixed and ready to be merged as PR

sseppi commented 11 months ago

@dulvui thank you for the changes, did you already do the PR?

@gappc shall we organize a meeting with Simon to do the review together and coordinate us for future PRs?

dulvui commented 11 months ago

@sseppi Yes PR are ready for review

gappc commented 11 months ago

@sseppi @dulvui i already merged the PR for this issue (#446). If you want we can schedule a meeting for the other PR (#445) or we can just merge it.

sseppi commented 11 months ago

@gappc you can just merge the PR #445, we will define after a coordination meeting with Simon

gappc commented 11 months ago

@sseppi @dulvui merge was done 👍

sseppi commented 11 months ago

Now it seems to be everything fine!