noi-techpark / it.bz.opendatahub.databrowser

Explore and navigate through Open Data you need to build your next service.
https://databrowser.opendatahub.com
GNU Affero General Public License v3.0
9 stars 7 forks source link

Bug: First publisher added does not work properly #447

Closed sseppi closed 1 year ago

sseppi commented 1 year ago

Image

Screenshot of the Publisher table after clicking the Add new publisher the first time:

Image

Screenshot of the Publisher table after clicking the Add new publisher the second time:

Image

sseppi commented 1 year ago

@gappc can you please have a look at this bug, so we can discuss it at the next refinement meeting?

sseppi commented 1 year ago

Same issue also noted in the Category and Data Provider table of the "Dataset Information" dataset

https://databrowser.opendatahub.testingmachine.eu/dataset/edit/tourism/v1/MetaData/01df71d7-7d48-491d-bcd2-e6e6d012e626

gappc commented 1 year ago

@sseppi that's a strange issue, it doesn't happen with the latest commit of the development branch (849621b2307efd44841d633b659dd4672d7461cb) when started locally. For example, if I open http://localhost:3000/dataset/edit/tourism/v1/ODHActivityPoi/dss_187043 and try to add a new publisher, it works as expected.

On the other side, if I try to do the same on https://databrowser.opendatahub.testingmachine.eu/dataset/edit/tourism/v1/ODHActivityPoi/dss_187043, then an error message appears (see below) and the behavior is the same as you mentioned. Is the same error message shown to you? All I can say is that the code tries to access a value that doesn't exist. Maybe that bug is already fixed in a current version?

image

It seems that the current development version and the version deployed to https://databrowser.opendatahub.testingmachine.eu differ. After the last modifications to the deployment configs, I'm not sure which version / commit is deployed to which URL. I'm also not sure when the deployments run. Could you please check with @dulvui?

In order to reduce friction and to simplify information gathering in case of errors I propose the following updates to the project:

gappc commented 1 year ago

@sseppi I further looked into the details of this bug, because it happens also e.g. here when logged in: https://databrowser.opendatahub.testingmachine.eu/dataset/edit/tourism/v1/WebcamInfo/11F3689902134955A087F384CB8B3E11#license

The problem is related to PR #432, where the existing component SelectWithOptionsCell was heavily modified and now exposes the buggy behavior. I'm going to take a look at a fix.

sseppi commented 1 year ago

@gappc will you investigate where the problem is, or shall we ask a-crea that made the PR #432 ?

dulvui commented 1 year ago

@sseppi @a-crea the PR is now merged and ready for testing on https://databrowser.opendatahub.testingmachine.eu

sseppi commented 1 year ago

Now the functionality seems to work properly.