search

noi-techpark / it.bz.opendatahub.databrowser

Explore and navigate through Open Data you need to build your next service.
https://databrowser.opendatahub.com
GNU Affero General Public License v3.0
8 stars 7 forks source link

Optimizing Editviews of various Datatypes #458

Closed RudiThoeni closed 7 months ago

RudiThoeni commented 7 months ago

This PR contains Optimizations and fixes for editing/inserting of various Datatypes including

RudiThoeni commented 7 months ago

Hi @gappc I now worked on the databrowser editview configuration because there were some fields wrongly assigned, wrong calls etc.... Maybe a short view over the code by your side would be nice ;)

In short what i did is:

thx and cheers

gappc commented 7 months ago

@RudiThoeni this merge was a bit premature, I didn't finish the code review ;) The most headache gives me the change in the linter config (see https://github.com/noi-techpark/it.bz.opendatahub.databrowser/pull/458/files/4e1ae0b1c0a4be567d063961db9cb819e88aa04b#diff-3442a35a9a3f19fe2fd90e1e6883488b32c707477fff45be7bca7db2a709e074). What was the problem on Windows? How does this change the linting behavior?

RudiThoeni commented 7 months ago

@cgapp i had some troubles with de CRLF, LF line endings (old linux/windows problem), without this config after a npm run lint -- --fix all files appeared as changed and i had CRLF as line endings..... By installing the VS Code prettier eslint extension it seems this problem is gone...... so i will remove this config in the next PR (see here https://github.com/noi-techpark/it.bz.opendatahub.databrowser/pull/469/commits/5719d439160c6e2184ec8ed0c407e5969ac35617)

gappc commented 7 months ago

@RudiThoeni good to know, maybe we should add this information to the developer docs. I'll give it a try and do a PR.

gappc commented 7 months ago

@RudiThoeni I've opened the issue #470 and have assigned it to me

RudiThoeni commented 7 months ago

@RudiThoeni good to know, maybe we should add this information to the developer docs. I'll give it a try and do a PR.

;) i found this config in this post here https://stackoverflow.com/questions/53516594/why-do-i-keep-getting-eslint-delete-cr-prettier-prettier

It is always a mess with this line endings on windows...

gappc commented 7 months ago

@RudiThoeni yeah, line endings... I agree 120% with what you say ;)