noi-techpark / it.bz.opendatahub.databrowser

Explore and navigate through Open Data you need to build your next service.
https://databrowser.opendatahub.com
GNU Affero General Public License v3.0
8 stars 7 forks source link

Feat/delete record from table view rebase #489

Closed a-crea closed 6 months ago

a-crea commented 6 months ago

This PR resolves #460

a-crea commented 6 months ago

Hi @gappc , please let me know if everything is in order. I had to create new branches and rearrange the code, so now everything should proceed smoothly :)

gappc commented 6 months ago

Hey @a-crea, impressive work, well done :+1:

I asked @RudiThoeni if I could do some merges during the weekend, he said ok, so if you want I can merge this PR

gappc commented 6 months ago

One thing came to my mind: would it be possible to extract the delete implementation from TableView.vue into something like useTableDelete? That would move complexity out of the TableView.vue

a-crea commented 6 months ago

@gappc would it cause problems to merge it as it is and then to apply the improvement? Each time I try to rebase it breaks the commits history... otherwise I could need your help to understand what is happening :/

I'm on Node 18 as suggested

gappc commented 6 months ago

@a-crea I think we can merge it now and apply the improvements afterwards. @RudiThoeni could you please merge this PR?

@a-crea given that rebasing causes trouble, we could schedule a meeting where we can take a look at how to fix errors associated with it.

RudiThoeni commented 6 months ago

done

RudiThoeni commented 6 months ago

the deployment did not pass, on build we get this errors Error: src/domain/datasets/ui/tableView/TableView.vue(134,5): error TS2554: Expected 1-2 arguments, but got 0. Error: Process completed with exit code 2.

gappc commented 6 months ago

@a-crea could you please take a look at the problem? Thx