Closed a-crea closed 6 months ago
Hi @gappc , please let me know if everything is in order. I had to create new branches and rearrange the code, so now everything should proceed smoothly :)
Hey @a-crea, impressive work, well done :+1:
I asked @RudiThoeni if I could do some merges during the weekend, he said ok, so if you want I can merge this PR
One thing came to my mind: would it be possible to extract the delete
implementation from TableView.vue into something like useTableDelete
? That would move complexity out of the TableView.vue
@gappc would it cause problems to merge it as it is and then to apply the improvement? Each time I try to rebase it breaks the commits history... otherwise I could need your help to understand what is happening :/
I'm on Node 18 as suggested
@a-crea I think we can merge it now and apply the improvements afterwards. @RudiThoeni could you please merge this PR?
@a-crea given that rebasing causes trouble, we could schedule a meeting where we can take a look at how to fix errors associated with it.
done
the deployment did not pass, on build we get this errors
Error: src/domain/datasets/ui/tableView/TableView.vue(134,5): error TS2554: Expected 1-2 arguments, but got 0.
Error: Process completed with exit code 2.
@a-crea could you please take a look at the problem? Thx
This PR resolves #460