noi-techpark / it.bz.opendatahub.databrowser

Explore and navigate through Open Data you need to build your next service.
https://databrowser.opendatahub.com
GNU Affero General Public License v3.0
8 stars 7 forks source link

Bug: Upload of a new file doesn't allow the user to save #497

Closed sseppi closed 5 months ago

sseppi commented 6 months ago

I tried to add a new file to the Event at the following link: https://databrowser.opendatahub.testingmachine.eu/dataset/edit/tourism/v1/EventShort/0e2082df-78f3-4ddd-b49b-e4f356385d2a#files Once i clicked on the Save & next button nothing happened.

To replicate the problem:

  1. Open the event: https://databrowser.opendatahub.testingmachine.eu/dataset/edit/tourism/v1/EventShort/0e2082df-78f3-4ddd-b49b-e4f356385d2a#files
  2. go to Edit view
  3. click on Files
  4. upload a new file
  5. add Document Name
  6. click on Save & next

The problem appears even if no or all Document Name are set.

In the Console I get the following error message: index-mNqr6iQp.js:1 SyntaxError: "undefined" is not valid JSON

More detail can be seen in the screenshot below:

Image

gappc commented 5 months ago

@sseppi @MatteoBiasi as I got assigned this issue, how can I help?

sseppi commented 5 months ago

@gappc I think it was my mistake... I will remove you for now.

@MatteoBiasi if you need support from Christian, please let me know and I will add him again.

gappc commented 5 months ago

@a-crea @MatteoBiasi I found the culprit in the EventDocumentCell component.

The bug was introduced with the PR #482 for mobility support, the reason for the problem is, that the language is passed as vue Ref instead of using the language value. PR #516 should fix the problem.

Please check if PR #516 works for you and let me know if you have further questions.

a-crea commented 5 months ago

@gappc Fixed with #516 :)