noi-techpark / it.bz.opendatahub.databrowser

Explore and navigate through Open Data you need to build your next service.
https://databrowser.opendatahub.com
GNU Affero General Public License v3.0
9 stars 7 forks source link

As a Data Browser user I want that the data coming from referenced calls are marked, to understand which calls I have to do to get the data I see. #533

Open sseppi opened 8 months ago

sseppi commented 8 months ago

The Data Browser user should be notified about the data that are shown in the Table or Detail view, but are not included in the original JSON but are coming from a second API call (e.g. the municipality name that comes from a second call to the municipality API). This issue includes:

sseppi commented 8 months ago

@pkritzinger can you please share the link to the design proposal you showed us during the last meeting?

pkritzinger commented 8 months ago

@sseppi find the updated design here. https://www.figma.com/file/DmuP6Dbv5LzkCNOXrDnWIL/2023-2024?type=design&node-id=2160%3A6390&mode=design&t=0LpELU8e1HEr8Sxf-1

pkritzinger commented 8 months ago

@sseppi updated design is here: https://www.figma.com/file/DmuP6Dbv5LzkCNOXrDnWIL/2023-2024?type=design&node-id=2160%3A6390&mode=design&t=r5SIC1xbmW0oWY9V-1

pkritzinger commented 5 months ago

@sseppi final design is here: https://www.figma.com/design/DmuP6Dbv5LzkCNOXrDnWIL/2023-2024?node-id=2451-2368&t=rjZ9BJAms4N0Zyk3-1

a-crea commented 2 months ago

Hi @gappc 😊

I'm trying to understand how to determine if an attribute should be considered referenced. Where can I find this information? I’ve noticed that some fields have a "Self" property in the API response. Should I use this value in the view and base the referenced value on it?

Thanks!

gappc commented 2 months ago

Hi @a-crea

I think that there is no real criteria in the API response / OpenAPI declaration, that shows when a field is referenced - at least not as of now. @RudiThoeni maybe the Self property is such one?

Be that as it may, my first idea was to use the dataset configuration and then have one or many components like the InputReferenceCell. That component knows how to load and show referenced data.

When e.g. the TableView sees that a column should be rendered with one of those dedicated components, it can apply a special color / border / ... to that column. Same goes for the DetailView / EditView.

You should also be able to infer from the configuration if there is any field / column at all that is a referenced value and which fields those are. That should enable you to render additional information e.g. in the Toolbox.

I hope you got the idea, how does it sound to you? Let me know if you have any further question or if you want to discuss solutions in a meeting :+1:

sseppi commented 1 month ago

@gappc here we need a meeting with Rudi, to finalize everything. Do I'm right?