search

noi-techpark / it.bz.opendatahub.databrowser

Explore and navigate through Open Data you need to build your next service.
https://databrowser.opendatahub.com
GNU Affero General Public License v3.0
8 stars 7 forks source link

Is "Quick view" description in doc / overview.md still valid? #552

Closed ohnewein closed 1 month ago

ohnewein commented 3 months ago

Should this paragraph been removed? Do we still have the "Quick view"?

https://github.com/noi-techpark/it.bz.opendatahub.databrowser/blob/development/doc/overview.md#visualization

gappc commented 2 months ago

@ohnewein @sseppi @mrabans technically, we still have the Quick view and it is used for datasets of type ODHActivityPoi.

You can see that there is a button on the left of ODHActivityPoi table view that opens the Quick view (https://databrowser.opendatahub.testingmachine.eu/dataset/table/tourism/v1/ODHActivityPoi).

image

Unfortunately, there seems to be a fresh bug in the Quick view, because it fails to show data when opened (e.g. https://databrowser.opendatahub.testingmachine.eu/dataset/quick/tourism/v1/ODHActivityPoi/smgpoifad01289740e1d2f58dc1aa29288bb33). The bug seems related to the Leaflet library that is used to show maps. I didn't take a look at it yet, because I'm not sure if the Quick view remains in place.

We should decide if we want to keep the Quick view. If it turns out that we want to keep it, we should plan what to do with this feature, because at the moment it is half-complete (ODHActivityPoi only). If it turns out that we don't need the Quick view, then I think it would be best to remove the feature and stuff related to it.

ohnewein commented 2 months ago

My suggestion would be to reduce complexity. If there are no users requesting it, I would remove it.

sseppi commented 2 months ago

@gappc

My suggestion would be to reduce complexity. If there are no users requesting it, I would remove it.

I agree with Patrick, let remove it. If users will ask for it, we will fix the bug and publish it again.

gappc commented 2 months ago

@ohnewein @sseppi PR #559 removes the Quick View

sseppi commented 2 months ago

@ohnewein @sseppi PR #559 removes the Quick View

@gappc Perfect! Thank you! Is the PR ready to be merged?

gappc commented 2 months ago

@sseppi yes it is ready

gappc commented 2 months ago

@ohnewein @sseppi @RudiThoeni the Quick View was removed as of commit 339544cda98d6ddb994c40a2eae3651f630bd229

If it's ok with you, we could close this issue.

sseppi commented 2 months ago

@RudiThoeni did you deploy this update also on production?

RudiThoeni commented 2 months ago

@sseppi no i wanted to do a production deploy today