noi-techpark / it.bz.opendatahub.databrowser

Explore and navigate through Open Data you need to build your next service.
https://databrowser.opendatahub.com
GNU Affero General Public License v3.0
9 stars 7 forks source link

BUG: missing save button on mobile #589

Closed sseppi closed 1 month ago

sseppi commented 3 months ago

Steps replicate the problem

  1. Access the Data Browser (testing environment: https://databrowser.opendatahub.testingmachine.eu/) on mobile
  2. Make the Login
  3. Access the "eCharging Station Accessibility" dataset: https://databrowser.opendatahub.testingmachine.eu/dataset/table/tourism/v1/ODHActivityPoi?tagfilter=electric+charging+stations
  4. Access the Edit Mode of one Station randomly: https://databrowser.opendatahub.testingmachine.eu/dataset/edit/tourism/v1/ODHActivityPoi/echarging_it*220*ebz000043
  5. Change randomly a data
pkritzinger commented 3 months ago

@sseppi agree. The screenshot below shows the expected behavior in the design.

image

gappc commented 3 months ago

@sseppi @pkritzinger the buttons were visible at the bottom of the screen, after scrolling down. PR #592 fixes that issue, it should works as expected after the merge.

gappc commented 3 months ago

@sseppi the PR was merged, should we close this ticket?

gappc commented 3 months ago

@sseppi the PR #592 did not resolve the problem 100%, I need to take another look at it

gappc commented 3 months ago

@sseppi please take a look at it e.g. https://9.databrowser.gappc.net/dataset/edit/tourism/v1/Accommodation/5E4BEFD440200CE4732A7FA30897C402

It should work now

sseppi commented 3 months ago

@sseppi please take a look at it e.g. https://9.databrowser.gappc.net/dataset/edit/tourism/v1/Accommodation/5E4BEFD440200CE4732A7FA30897C402

It should work now

@gappc now it seems to work properly, can you please close the PR #595 that is stil marked as Draft? Then I will accept the PR you did and test it again in the testing environment.

gappc commented 1 month ago

@sseppi seems to work (see e.g. https://databrowser.opendatahub.testingmachine.eu/dataset/edit/tourism/v1/Accommodation/5E4BEFD440200CE4732A7FA30897C402#contact), can we close this issue?

sseppi commented 1 month ago

@gappc I tested on my mobile phone and everything seems to work fine now. I close the issue.